fix: operator chart imagePullPolicy

[ls-2018]

Overview:

fix: operator chart imagePullPolicy

Details:

Where should the reviewer start?

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

• closes GitHub issue: #xxx

Summary by CodeRabbit

• Chores
  • Enhanced deployment configuration to support configurable container image pull policies, improving operational flexibility.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[copy-pr-bot]

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

[github-actions]

👋 Hi ls-2018! Thank you for contributing to ai-dynamo/dynamo.

Just a reminder: The NVIDIA Test Github Validation CI runs an essential subset of the testing framework to quickly catch errors.Your PR reviewers may elect to test the changes comprehensively before approving your changes.

🚀

[coderabbitai]

Walkthrough

Two imagePullPolicy configurations were added to containers in a Kubernetes Helm deployment template, sourcing the policy value from the controllerManager manager image configuration in the values file.

Changes

Cohort / File(s)	Change Summary
Helm Deployment Configuration deploy/cloud/helm/platform/components/operator/templates/deployment.yaml	Added imagePullPolicy fields to kube-rbac-proxy and manager containers, both sourced from {{ .Values.controllerManager.manager.image.pullPolicy | quote }}

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

• Single file modified with repetitive, straightforward configuration additions
• No logic changes, control flow modifications, or error handling alterations
• Values reference consistency should be briefly verified

Poem

🐰 A rabbit hops through the deployment so bright,
Adding pull policies left and right,
Kube-rbac-proxy gets dressed with care,
Manager container gets its share,
From values they spring, a config delight! 🎉

Pre-merge checks

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description follows the template structure but is largely incomplete with placeholder text and missing substantive content in critical sections.	Fill in the Details section with a description of the imagePullPolicy changes, specify which files to review, and replace the placeholder issue reference with the actual related issue number.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically describes the main change: adding imagePullPolicy configuration to the operator chart deployment.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1e37c10 and d2b82e5.

📒 Files selected for processing (1)

• deploy/cloud/helm/platform/components/operator/templates/deployment.yaml (2 hunks)

🧰 Additional context used

🧠 Learnings (3)

📓 Common learnings

Learnt from: julienmancuso
Repo: ai-dynamo/dynamo PR: 1337
File: deploy/cloud/helm/platform/components/operator/templates/image-builer-serviceaccount.yaml:0-0
Timestamp: 2025-06-03T15:26:55.732Z
Learning: The image-builder ServiceAccount in deploy/cloud/helm/platform/components/operator/templates/image-builer-serviceaccount.yaml does not need imagePullSecrets, unlike the component ServiceAccount.

📚 Learning: 2025-06-03T15:26:55.732Z

Learnt from: julienmancuso
Repo: ai-dynamo/dynamo PR: 1337
File: deploy/cloud/helm/platform/components/operator/templates/image-builer-serviceaccount.yaml:0-0
Timestamp: 2025-06-03T15:26:55.732Z
Learning: The image-builder ServiceAccount in deploy/cloud/helm/platform/components/operator/templates/image-builer-serviceaccount.yaml does not need imagePullSecrets, unlike the component ServiceAccount.

Applied to files:

• deploy/cloud/helm/platform/components/operator/templates/deployment.yaml

📚 Learning: 2025-09-17T22:35:40.674Z

Learnt from: julienmancuso
Repo: ai-dynamo/dynamo PR: 3100
File: deploy/cloud/operator/cmd/main.go:186-190
Timestamp: 2025-09-17T22:35:40.674Z
Learning: The mpiRunSecretName validation in deploy/cloud/operator/cmd/main.go is safe for Helm-based upgrades because the chart automatically provides default values (secretName: "mpi-run-ssh-secret", sshKeygen.enabled: true) and the deployment template conditionally injects the --mpi-run-ssh-secret-name flag, ensuring existing installations get the required configuration during upgrades.

Applied to files:

• deploy/cloud/helm/platform/components/operator/templates/deployment.yaml

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Build and Test - dynamo

🔇 Additional comments (2)

deploy/cloud/helm/platform/components/operator/templates/deployment.yaml (2)

157-159: Consistent imagePullPolicy configuration for manager container.

The manager container consistently sources both its image (repository, tag) and imagePullPolicy from controllerManager.manager.image.*, which is the correct pattern.

---

66-69: The code snippet and concerns in this review comment do not match the current state of the deployment.yaml file. The imagePullPolicy field does not exist in the kube-rbac-proxy container configuration (or anywhere else in the deployment). Additionally, the values.yaml file does not define pullPolicy under either controllerManager.kubeRbacProxy.image or controllerManager.manager.image. No changes are needed at this time.

Likely an incorrect or invalid review comment.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}