Skip to content

Conversation

@TheDuyIT
Copy link

@TheDuyIT TheDuyIT commented Dec 11, 2025

Overview:

Add ValueError handling
Propagate 400 error code when python generator raise ValueError

Details:

Python async generator might perform some validations and raises exception such as ValueError. Dynamo receives the exception and response 500 error.
This PR add logic to catch ValueError from python generator and propagate 400 error to the response.

Logic for grpc hasn't been implemented yet.

Where should the reviewer start?

lib/bindings/python/rust/engine.rs:

lib/llm/src/http/service/openai.rs: error code propagation

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • closes GitHub issue: #xxx

@copy-pr-bot
Copy link

copy-pr-bot bot commented Dec 11, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions
Copy link

👋 Hi TheDuyIT! Thank you for contributing to ai-dynamo/dynamo.

Just a reminder: The NVIDIA Test Github Validation CI runs an essential subset of the testing framework to quickly catch errors.Your PR reviewers may elect to test the changes comprehensively before approving your changes.

🚀

@github-actions github-actions bot added the external-contribution Pull request is from an external contributor label Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external-contribution Pull request is from an external contributor size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant