Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
Add ValueError handling
Propagate 400 error code when python generator raise ValueError
Details:
Python async generator might perform some validations and raises exception such as ValueError. Dynamo receives the exception and response 500 error.
This PR add logic to catch ValueError from python generator and propagate 400 error to the response.
Logic for grpc hasn't been implemented yet.
Where should the reviewer start?
lib/bindings/python/rust/engine.rs:
lib/llm/src/http/service/openai.rs: error code propagation
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)