-
Notifications
You must be signed in to change notification settings - Fork 744
feat: Add logprobs support to SGLang backend #4912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AryanBagade
wants to merge
9
commits into
ai-dynamo:main
Choose a base branch
from
AryanBagade:feat/add-logprobs-support-sglang-backend
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
85ff86c
feat: Add logprobs support to SGLang backend closes: #4685
AryanBagade 32486d5
Merge branch 'main' into feat/add-logprobs-support-sglang-backend
AryanBagade 246ab54
fix: address CodeRabbit review feedback for SGLang logprobs
AryanBagade 1cf26f9
Merge branch 'main' into feat/add-logprobs-support-sglang-backend
AryanBagade 0e60cfd
fix: use logging module directly per review feedback
AryanBagade 45fb04e
Merge branch 'main' into feat/add-logprobs-support-sglang-backend
AryanBagade 2420fc9
fix: pass logprobs params to async_generate not SamplingParams SGLang…
AryanBagade b1da340
Merge branch 'main' into feat/add-logprobs-support-sglang-backend
AryanBagade 80c7d8c
Merge branch 'main' into feat/add-logprobs-support-sglang-backend
AryanBagade File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wdyt about moving this into handler base?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had some digging here, basically the extraction logic is backend-specific since SGLang returns logprobs as tuples (logprob, token_id, decoded_text) which differs from TRTLLM's structure.
vLLM also keeps its _extract_logprobs in handlers.py rather than a shared base for the same reason. Happy to refactor if you see a clean abstraction though!