Add bump, for now as an option #17
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we need to take our time to discuss more about it but to have at least a first common version just add it as an option
hparfr
reviewed
Feb 13, 2025
Comment on lines
+64
to
+66
| subprocess.run(f"git tag {version}", shell=True, check=True) | ||
| subprocess.run("git push origin --tag", shell=True, check=True) | ||
| subprocess.run(f"git push origin {ODOO_VERSION}", shell=True, check=True) |
Member
There was a problem hiding this comment.
Suggested change
| subprocess.run(f"git tag {version}", shell=True, check=True) | |
| subprocess.run("git push origin --tag", shell=True, check=True) | |
| subprocess.run(f"git push origin {ODOO_VERSION}", shell=True, check=True) | |
| subprocess.run("git push origin", shell=True, check=True) | |
| subprocess.run(f"glab ci trigger publish", shell=True, check=True) |
| def get_before_request(cr): | ||
| cr.execute("SELECT latest_version FROM ir_module_module WHERE name='custom_all'") | ||
| todo = [] | ||
| db_version = cr.fetchone() |
Member
There was a problem hiding this comment.
We should add something like :
db_version = db_version and db_version[0] or False
Because the result of the sql query is None if custom_all does not exists in ir_module_module (which is fine)
But it is (None,) if it exists but is not installed. Which is evaluated as True and make the script to fail later.
Of course the line db_version = db_version[0] above should then be removed.
@sebastienbeau
| todo = [] | ||
| db_version = cr.fetchone() | ||
| if not db_version: | ||
| _logger.error("No version found for custom_all, skip begin script") |
Member
There was a problem hiding this comment.
Well, it misses a return todo here I guess... Because right now, the script is not skipped and will fail when comparing None to the version !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we need to take our time to discuss more about it
but to have at least a first common version just add it as an option