fix(controller): make git repo retain url suitable for use by external callers of URL() method

[krancour]

Fixes #5344

Internally, implementations of git.Repo hang on to URLs that often contain @username, but callers of the URL() method rightfully expect it to return the original URL that was provided to the git.Clone() or git.CloneBare() function.

[netlify]

✅ Deploy Preview for docs-kargo-io ready!

Name	Link
🔨 Latest commit	2ee2423
🔍 Latest deploy log	https://app.netlify.com/projects/docs-kargo-io/deploys/690b7e1c0dc9e10008312bdb
😎 Deploy Preview	https://deploy-preview-5350.docs.kargo.io
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[codecov]

Codecov Report

❌ Patch coverage is 49.27536% with 35 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.93%. Comparing base (1c8f307) to head (2ee2423).

Files with missing lines	Patch %	Lines
pkg/controller/git/work_tree.go	0.00%	29 Missing ⚠️
pkg/controller/git/base_repo.go	75.00%	3 Missing and 1 partial ⚠️
pkg/controller/git/bare_repo.go	94.11%	1 Missing ⚠️
pkg/controller/git/repo.go	85.71%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5350      +/-   ##
==========================================
- Coverage   55.95%   55.93%   -0.03%     
==========================================
  Files         407      407              
  Lines       29906    29939      +33     
==========================================
+ Hits        16735    16745      +10     
- Misses      12200    12222      +22     
- Partials      971      972       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[hiddeco]

I find the internalURL and externalURL naming quite confusing. Would something like url (or operationalURL) and canonicalURL maybe be better?

[krancour]

Now that you've pointed it out, I agree the names aren't intuitive. You'd need to read the comments to understand. "Canonical" doesn't work because it's too similar to "normalized," and there's no real giant this is normalized. I'll noodle on this a bit. I agree there's a better naming scheme somewhere here that I've overlooked.