-
Notifications
You must be signed in to change notification settings - Fork 86
feat: add revert check to mempool add #1166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dancoombs
wants to merge
4
commits into
main
Choose a base branch
from
danc/revert-check
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files
... and 1 file with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Collaborator
Author
|
Looks like we need to update the geth version in the 06 compliance tests |
e8fc7c9 to
acd7204
Compare
acd7204 to
7634447
Compare
7634447 to
e3efd63
Compare
dancoombs
commented
Nov 26, 2025
dancoombs
commented
Nov 26, 2025
dancoombs
commented
Nov 26, 2025
dancoombs
commented
Nov 26, 2025
dancoombs
commented
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
eth_simulateV1- this should be used on most networks as its much more efficientdebug_traceCalleth_call- this does not catch postop reverts, but does catch full execution reverts, only useful on monad at the moment.TODO
simulateHandleOpand add support for aggregated user ops