[WIP]refactor: use static init instead of call_once. #672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanyokwok
reviewed
Sep 30, 2022
| // clang-format off | ||
|
|
||
| const std::unordered_set<std::string> &GetTorchMlirWhiteList() { | ||
| static std::unordered_set<std::string> white_list = CreateTorchMlirWhiteList(); |
Collaborator
There was a problem hiding this comment.
Nit: Could you please link the c++ 11 standard doc reference?
Contributor
Author
There was a problem hiding this comment.
please refer to this SO answer or C++11 standard 6.7
|
Shen Li seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Static var initialization is guaranteed to be called once by c++11 standard. Maybe we can remove some call_once usages for simplicity (and maybe small perf gain).