feat: rax jsx runtime by 7213 · Pull Request #2101 · alibaba/rax

7213 · 2021-03-10T04:45:42Z

Support jsx-runtime

This module is adapted to react's jsx-runtime module. For more information, please see：introducing-the-new-jsx-transform

usage

{
  "presets": [
    [
      "@babel/preset-react",
      {
        "runtime": "automatic",
        "importSource": "rax/jsx-runtime"
      }
    ]
  ]
}

CLAassistant · 2021-03-10T04:45:54Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

songzheng seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

SoloJiang · 2021-04-06T06:29:02Z

这个包直接打在 rax 里就好了吧？

7213 · 2021-04-08T05:32:46Z

这个包直接打在 rax 里就好了吧？

jsx runtime应该避免使用者对具体jsx库的感知。由编译器自动引入 import {jsx as _jsx} from "xx-jsx-runtime" 应该放到单独的包更合适点。

SoloJiang · 2021-04-12T06:52:25Z

这个包直接打在 rax 里就好了吧？

jsx runtime应该避免使用者对具体jsx库的感知。由编译器自动引入 import {jsx as _jsx} from "xx-jsx-runtime" 应该放到单独的包更合适点。

react 现在是怎么做的？

SoloJiang · 2021-04-12T06:58:36Z

编译成这样是不是更好：rax/jsx-runtime

独立包造成的问题是，runtime 核心能力和 rax 核心包之间可能存在版本差异问题，以及开发者是否感知到这个包的版本

7213 · 2021-04-12T09:54:38Z

编译成这样是不是更好：rax/jsx-runtime

独立包造成的问题是，runtime 核心能力和 rax 核心包之间可能存在版本差异问题，以及开发者是否感知到这个包的版本

react是在react package里，已放入jsx-runtime放在rax包中。

SoloJiang · 2021-04-16T18:10:36Z

commit 信息可以明确点
jsxs/jsx/jsxDEV 应该是不一样的 3 个方法

This module is adapted to react's jsx-runtime module. Implement Babel's "automatic" JSX runtime API: * 1.jsx(type, props, key) * 2.jsxs(type, props, key) * 3.jsxDEV(type, props, key, __source, __self)

7213 · 2021-04-17T12:53:08Z

commit 信息可以明确点

jsxs/jsx/jsxDEV 应该是不一样的 3 个方法

react实现中：jsxs是jsx完全等价的别名哈
jsxDEV babel编译时会自动注入source和self调试信息，generateVNode 的实现均已包含

SoloJiang · 2021-04-18T15:06:03Z

我指的不是生产模式

SoloJiang · 2021-04-18T15:22:34Z

packages/rax/src/jsx-runtime/index.js

+      }
+  }
+
+  return {


最后返回 RaxElement 是不是更好点

7213 · 2021-04-19T02:55:19Z

我指的不是生产模式

我来处理，目前是为了体积进行了最小实现，忽略了DEV环境下jsx、jsxs对DEV下校验部分的代码区别

SoloJiang · 2021-04-19T06:33:27Z

可以通过环境变量移除掉 DEV 的代码

1.jsx-runtime和createElement组织结构保持一致 2.区分环境导出不同jsx-runtime，和react一致

SoloJiang · 2021-04-19T14:00:41Z

packages/rax/jsx-dev-runtime.js

@@ -0,0 +1 @@
+export {Fragment, jsxDEV} from './index';


大括号前后加个空格 export { Fragment }....

ok,不过npm run lint:fix似乎没有自动修正这个style

仓库有点老，没敢升级新的 lint 规则 =。=

SoloJiang · 2021-04-19T14:00:47Z

packages/rax/jsx-runtime.js

@@ -0,0 +1 @@
+export {Fragment, jsx, jsxs, jsxDEV} from './index';


SoloJiang · 2021-04-19T14:02:40Z

packages/rax/src/vdom/element.js

+      writable: true,
+      value: __self
+    });
+  }


这里抽成一个 utils，避免浪费体积

SoloJiang · 2021-04-19T14:07:08Z

packages/rax/src/jsx-runtime.js

+  return _jsxWithValidation(type, props, key, true, __source, __self);
+}
+
+const jsx = __DEV__ ? jsxWithValidation : jsxRuntime;


jsxWithValidation 用额外的文件实现，避免最后生产代码里还遗存

优化构建体积

SoloJiang

整体没啥大的问题了，这两天我来切个 next 分支

SoloJiang · 2021-04-19T14:53:45Z

packages/rax/src/vdom/jsxValidator.js

+export function jsxWithValidation(type, props, key) {
+  return _jsxWithValidation(type, props, key, false);
+}
+export function jsxsWithValidation(type, props, key) {


这里的函数命名可以参考 React，可读性更强一点

修改jsxValidator导出的命名

7213 · 2021-04-23T05:45:34Z

整体没啥大的问题了，这两天我来切个 next 分支

ok，到时我逐步提供为Rax App提供一个jsx-runtime的版本

yuchonghua · 2021-11-24T03:53:41Z

rax 近期能发一个支持jsx-runtime 的版本吗

yuchonghua · 2021-11-24T03:59:09Z

期待有更多rax的文档，而非rax-app的文档

SoloJiang · 2021-11-24T04:13:56Z

rax 近期能发一个支持jsx-runtime 的版本吗

双十二之后发布

yuchonghua · 2022-03-21T15:43:14Z

rax 近期能发一个支持jsx-runtime 的版本吗

双十二之后发布

您好，最近这个有推进吗？已经3月了哦

songzheng added 3 commits March 10, 2021 12:32

feat: jsx-runtime

b09bac3

feat: jsx-runtime

52c3268

feat: jsx-runtime

eaf2e27

7213 changed the title ~~Feat/rax jsx runtime~~ feat:rax jsx runtime Mar 23, 2021

7213 changed the title ~~feat:rax jsx runtime~~ feat: rax jsx runtime Mar 23, 2021

SoloJiang mentioned this pull request Apr 12, 2021

[Feature] Rax support the new jsx-runtime #2097

Open

songzheng added 3 commits April 12, 2021 18:40

feat: jsx-runtime

78cc660

feat: jsx-runtime

be9d1e4

feat: jsx-runtime

f895d08

feat: jsx-runtime

ef8bb58

This module is adapted to react's jsx-runtime module. Implement Babel's "automatic" JSX runtime API: * 1.jsx(type, props, key) * 2.jsxs(type, props, key) * 3.jsxDEV(type, props, key, __source, __self)

SoloJiang reviewed Apr 18, 2021

View reviewed changes

packages/rax/src/jsx-runtime/index.js Outdated

}

}

return {

Copy link

Collaborator

SoloJiang Apr 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

最后返回 RaxElement 是不是更好点

songzheng added 3 commits April 19, 2021 17:46

feat: jsx-runtime

b85968f

1.jsx-runtime和createElement组织结构保持一致 2.区分环境导出不同jsx-runtime，和react一致

feat: jsx-runtime

4979a61

1.jsx-runtime和createElement组织结构保持一致 2.区分环境导出不同jsx-runtime，和react一致

feat: jsx-runtime

0c2c2b3

1.jsx-runtime和createElement组织结构保持一致 2.区分环境导出不同jsx-runtime，和react一致

7213 requested a review from SoloJiang April 19, 2021 11:32

SoloJiang reviewed Apr 19, 2021

View reviewed changes

packages/rax/jsx-runtime.js Outdated

@@ -0,0 +1 @@

export {Fragment, jsx, jsxs, jsxDEV} from './index';

Copy link

Collaborator

SoloJiang Apr 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

SoloJiang reviewed Apr 19, 2021

View reviewed changes

packages/rax/src/vdom/element.js

writable: true,

value: __self

});

}

Copy link

Collaborator

SoloJiang Apr 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里抽成一个 utils，避免浪费体积

SoloJiang reviewed Apr 19, 2021

View reviewed changes

feat: jsx-runtime

2632b35

优化构建体积

SoloJiang reviewed Apr 19, 2021

View reviewed changes

songzheng added 2 commits April 20, 2021 10:00

feat: jsx-runtime

b57b666

修改jsxValidator导出的命名

feat: jsx-runtime

22f1efa

修改jsxValidator导出的命名

SoloJiang mentioned this pull request May 31, 2021

[Question]有没有什么好的办法兼容react默认导入React而不是{createElement}？ #2133

Closed

SoloJiang mentioned this pull request Oct 26, 2021

[Feature] Rax and Mdx #2276

Closed

		@@ -0,0 +1 @@
		export {Fragment, jsx, jsxs, jsxDEV} from './index';

Conversation

7213 commented Mar 10, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Support jsx-runtime

usage

Uh oh!

CLAassistant commented Mar 10, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SoloJiang commented Apr 6, 2021

Uh oh!

7213 commented Apr 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SoloJiang commented Apr 12, 2021

Uh oh!

SoloJiang commented Apr 12, 2021

Uh oh!

7213 commented Apr 12, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SoloJiang commented Apr 16, 2021

Uh oh!

7213 commented Apr 17, 2021

Uh oh!

SoloJiang commented Apr 18, 2021

Uh oh!

SoloJiang Apr 18, 2021

Choose a reason for hiding this comment

Uh oh!

7213 commented Apr 19, 2021

Uh oh!

SoloJiang commented Apr 19, 2021

Uh oh!

SoloJiang Apr 19, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

7213 Apr 19, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SoloJiang Apr 19, 2021

Choose a reason for hiding this comment

Uh oh!

SoloJiang Apr 19, 2021

Choose a reason for hiding this comment

Uh oh!

SoloJiang Apr 19, 2021

Choose a reason for hiding this comment

Uh oh!

SoloJiang Apr 19, 2021

Choose a reason for hiding this comment

Uh oh!

SoloJiang left a comment

Choose a reason for hiding this comment

Uh oh!

SoloJiang Apr 19, 2021

Choose a reason for hiding this comment

Uh oh!

7213 commented Apr 23, 2021

Uh oh!

yuchonghua commented Nov 24, 2021

Uh oh!

yuchonghua commented Nov 24, 2021

Uh oh!

SoloJiang commented Nov 24, 2021

Uh oh!

yuchonghua commented Mar 21, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

7213 commented Mar 10, 2021 •

edited

Loading

CLAassistant commented Mar 10, 2021 •

edited

Loading

7213 commented Apr 8, 2021 •

edited

Loading

7213 commented Apr 12, 2021 •

edited

Loading

SoloJiang Apr 19, 2021 •

edited

Loading

7213 Apr 19, 2021 •

edited

Loading