Add Utah Teapot demo and object loading #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Useful if embedding the .obj using TH
The vectors we read from can be Storable or not. It doesn't matter when reading so no point in forcing a conversion just to do the lookups. Now the function returns normal Vectors, which can be converted by the user with V.convert after the fact.
I mistakenly thought this for a GHC bug (#26605) because I wasn't using checked bounds.
Needs cull-mode = None, or Front for good results Does that mean we're doing triangle order wrong?! Try more meshes...
alt-romes
force-pushed
the
wip/romes/teapot
branch
from
e5ce8a5 to
38de01f
Compare
Contributor
|
Excellent work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@walseb here's some progress :)
One slight thing I'm concerned about is that I needed to set cull mode = Front for this to work. But I thought that .obj used counter clockwise faces and that the engine was using the same type, so it should match by default. Something slightly odd but I'll take a closer look later.