Fixed compiling error #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DevManu-de
changed the title
Contributor
Author
|
Makefile now requires c11 yet enables posix extension |
Fixed compiling and added tinfo link Removed tinfo link Reduced compiler version
ajccosta
force-pushed
the
compiler-error
branch
from
75d543a to
a070366
Compare
Collaborator
|
Perfect thanks :). Just added attribute((unused)) to prevent the compiler warning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issues described in #103 are fixed.
They were undetected beacuse gcc used an older compiler version which did not raise an error.
I changed the code to be compliant with c23 and set this in the Makefile thus future changes in the default compiler version continue to compile.
The pull request #100 should also be considered to be merged as it may result in compiler errors because some systems separate ncurses and tinfo more strictly and thus result in an error.