Fix ArgumentCountError in test token_fetcher closures#96
Merged
dan2k3k4 merged 2 commits intoadd-trigger-deploy-and-lagoon-commandfrom Mar 16, 2026
Merged
Fix ArgumentCountError in test token_fetcher closures#96dan2k3k4 merged 2 commits intoadd-trigger-deploy-and-lagoon-commandfrom
dan2k3k4 merged 2 commits intoadd-trigger-deploy-and-lagoon-commandfrom
Conversation
…rameter Co-authored-by: dan2k3k4 <158704+dan2k3k4@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on Lagoon Deployments for App Instances
Fix ArgumentCountError in test token_fetcher closures
Mar 16, 2026
dan2k3k4
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LagoonClientService::getLagoonToken()invokes thepolydock.lagoon.token_fetchercallable with the$configarray, but tests were binding zero-arg closures — causing anArgumentCountErrorat runtime.Changes
tests/Feature/Console/Commands/RunLagoonCommandOnAppInstancesTest.php: Updated bothtest_it_runs_serially_by_defaultandtest_it_skips_instances_missing_metadatato bind a callable that accepts the config parameter:💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.