refactor: Admin UI Trigger Deploy uses LagoonClientService directly (not Artisan CLI wrapper)#97
Merged
dan2k3k4 merged 2 commits intoadd-trigger-deploy-and-lagoon-commandfrom Mar 16, 2026
Conversation
…tion Co-authored-by: dan2k3k4 <158704+dan2k3k4@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on Lagoon Deployments for App Instances
refactor: Admin UI Trigger Deploy uses LagoonClientService directly (not Artisan CLI wrapper)
Mar 16, 2026
dan2k3k4
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Trigger Deployadmin action was calling thepolydock:app-instance:trigger-deployArtisan command viaArtisan::call(), obscuring that the mechanism is the Lagoon API — not the CLI. Both the deployment action and the deployment info form section now callLagoonClientServicedirectly.Changes
ViewPolydockAppInstance.phpArtisan::call('polydock:app-instance:trigger-deploy', ...)with a directLagoonClientService::getAuthenticatedClient()+deployProjectEnvironmentByName()callLagoonClientService::getLagoonToken()(cached) +buildClientWithToken()— same caching behaviour, no more duplicated config wiringArtisan,Client,SshLagoonClientService.phpgetLagoonToken()promoted fromprotectedtopublicwith an optional$configparam (defaults togetClientConfig()) — enables external token cachingbuildClientWithToken(array $config, string $token): Client— constructs a configured client from a pre-fetched token;getAuthenticatedClient()now delegates to it💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.