fix: parse Python cp tag for unitree/booster wheel URLs; bump unitree to 0.1.3#104
Merged
kingb merged 2 commits intoMay 12, 2026
Merged
Conversation
… to 0.1.3 setup.py hardcoded cp310 in the wheel URL template, so `pip install .[unitree]` on Python 3.11/3.12 built a 404 URL. Parse sys.version_info to pick the matching cp tag from the wheel build matrix (cp38/cp310/cp311/cp312), and bump UNITREE_VERSION to 0.1.3 so the correct wheel file is fetched. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
tomasz-lewicki
requested changes
May 8, 2026
Contributor
tomasz-lewicki
left a comment
tomasz-lewicki
left a comment
There was a problem hiding this comment.
LGTM except for the cp_tag implicit default.
Address review feedback: fall-through to cp310 masked the real problem. Now raise a RuntimeError listing supported versions at setup-time so the install failure is explicit.
tomasz-lewicki
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the
unitree_sdk2andbooster_robotics_sdkwheel URL construction insrc/holosoma_inference/setup.pysopip install -e .[unitree,booster]works on Python ≥ 3.11.Previously:
UNITREE_VERSION = "0.1.1"hardcoded.cp310-cp310in both SDKs' URL patterns.On Python 3.11 or 3.12 the install would fetch a
cp310wheel URL and fail (at best) or silently install the wrong ABI (at worst).Changes
UNITREE_VERSIONto0.1.3(latest release; shipscp38/cp310/cp311/cp312 × aarch64/x86_64wheels).sys.version_infoto pick the matchingcp{X}{Y}tag from a supported set{(3,8), (3,10), (3,11), (3,12)}.RuntimeErroron unsupported Python versions (listing the supported set) so the install failure is explicit rather than silently mis-tagged.Why now
JetPack 7.1 / Ubuntu 24.04 (Noble) native Python is 3.12, and that's the target for the upcoming Thor Docker image. Without this fix, the
inferenceDocker layer can't install the[unitree]extra.Test plan
cp{X}{Y}tag.pip install -e src/holosoma_inference[unitree,booster]on Python 3.10,linux/amd64→ fetchescp310wheels;unitree_interfaceandbooster_robotics_sdkimport successfully.pip install -e src/holosoma_inference[unitree,booster]on Python 3.12,linux/amd64→ fetchescp312wheels; imports successfully (depends on Bump version to 0.1.3 unitree_sdk2#10 — merged).RuntimeErrorlisting supported versions.