Adding further aie4 shim test support #895

hlaccabu · 2025-12-03T21:22:25Z

No description provided.

Copilot

Pull request overview

This PR extends AIE4 support in the shim test suite by introducing a new debug buffer type (XRT_BO_USE_UC_DEBUG) and broadening test coverage from AIE2-specific to general AIE platform support. The changes enable debug buffer operations to work correctly on AIE4 devices while maintaining backward compatibility with AIE2.

Introduced XRT_BO_USE_UC_DEBUG buffer type for AIE4 debug operations
Extended test coverage from AIE2-only to all AIE platforms for several test cases
Updated buffer creation logic to conditionally use appropriate debug flags based on device type

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
test/shim_test/shim_test.cpp	Conditionally selects debug buffer flags based on AIE4 detection and broadens test filters from AIE2-specific to general AIE support
src/shim/buffer.cpp	Adds mapping for new XRT_BO_USE_UC_DEBUG buffer type to firmware debug buffer type

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-03T21:22:49Z

src/shim/buffer.cpp

+  case XRT_BO_USE_UC_DEBUG:
+    return AMDXDNA_FW_BUF_DEBUG;


The new XRT_BO_USE_UC_DEBUG case returns the same firmware buffer type as XRT_BO_USE_DEBUG. Add a comment explaining why both buffer use types map to the same firmware type, or if they should have different behaviors.

This is reasonable. @hlaccabu can you add some comments here?

xdavidz

With this, can we get a pass when run "shim_test" without any index number?

Signed-off-by: Hayden Laccabue <[email protected]>

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 7 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-06T00:34:41Z

test/shim_test/shim_test.cpp

  auto dev = sdev.get();
  auto boflags = XRT_BO_FLAGS_CACHEABLE;
-  auto ext_boflags = XRT_BO_USE_DEBUG << 4;
+  auto ext_boflags = dev_filter_is_aie4(id, dev) ? (XRT_BO_USE_UC_DEBUG << 4) : (XRT_BO_USE_DEBUG << 4);


The variable name ext_boflags is ambiguous. Consider renaming to extended_bo_flags for clarity.

Copilot · 2026-01-06T00:34:41Z

test/shim_test/io_test.cpp

-    for (auto& cmd : cmdlist_bos) {
+    for (size_t i = 0; i < cmdlist_bos.size(); i++) {
+      auto& cmd = cmdlist_bos[i];
+


Empty line within conditional logic reduces readability. Consider removing this blank line between the comment and the conditional check.

Suggested change

Copilot · 2026-01-06T00:34:42Z

test/shim_test/io_test.cpp

+      if (bo_set_ptr && i < bo_set_ptr->size()) {
+        std::atomic_thread_fence(std::memory_order_acquire);
+      }
+


Unnecessary blank line after memory fence. Consider removing for consistency.

Suggested change

Copilot · 2026-01-06T00:34:42Z

test/shim_test/io_test.cpp

      if (completed >= total_cmd_submission)
        break;
-      std::get<1>(cmd)->state = ERT_CMD_STATE_NEW;
+


Unnecessary blank line before conditional. Consider removing for consistency.

Suggested change

Copilot · 2026-01-06T00:34:42Z

test/shim_test/io_test.cpp

-    std::get<1>(cmd)->state = ERT_CMD_STATE_NEW;
+    if (!bo_set_ptr)
+      std::get<1>(cmd)->state = ERT_CMD_STATE_NEW;
+


Unnecessary blank line after state assignment. Consider removing for consistency.

Suggested change

Copilot · 2026-01-06T00:34:42Z

test/shim_test/io_test.cpp

+        (*bo_set_ptr)[wait_idx]->restore_cmd_header();
+      else
+        std::get<1>(cmdlist_bos[wait_idx])->state = ERT_CMD_STATE_NEW;
+


Unnecessary blank line after conditional restore logic. Consider removing for consistency.

Suggested change

Copilot · 2026-01-06T00:34:43Z

test/shim_test/hwctx.h

-    auto is_full_elf = (get_kernel_type(dev, xclbin_name) == KERNEL_TYPE_TXN_FULL_ELF_PREEMPT);
+    auto kernel_type = get_kernel_type(dev, xclbin_name);
+    auto is_full_elf = (kernel_type == KERNEL_TYPE_TXN_FULL_ELF_PREEMPT ||
+			kernel_type == KERNEL_TYPE_TXN_FULL_ELF);


Inconsistent indentation: line 39 uses tabs while the codebase appears to use spaces. Ensure consistent whitespace usage.

Suggested change

kernel_type == KERNEL_TYPE_TXN_FULL_ELF);

kernel_type == KERNEL_TYPE_TXN_FULL_ELF);

hlaccabu requested a review from xdavidz December 3, 2025 21:22

hlaccabu added the do-not-merge label Dec 3, 2025

Copilot AI review requested due to automatic review settings December 3, 2025 21:22

Copilot AI reviewed Dec 3, 2025

View reviewed changes

xdavidz reviewed Dec 6, 2025

View reviewed changes

hlaccabu added the multi-repo label Dec 18, 2025

hlaccabu force-pushed the shim branch from 4fa9d38 to db21bc3 Compare December 18, 2025 22:34

hlaccabu added 3 commits January 5, 2026 11:10

Adding further aie4 shim test support

6fb81f5

Signed-off-by: Hayden Laccabue <[email protected]>

Remove umq_tests, covered by xrt_test + vadd in shim_test

5fc2b89

Signed-off-by: Hayden Laccabue <[email protected]>

Creating shim io test support for npu3 full elf flow

e0c0e71

Signed-off-by: Hayden Laccabue <[email protected]>

hlaccabu force-pushed the shim branch from db21bc3 to e0c0e71 Compare January 6, 2026 00:33

Copilot AI review requested due to automatic review settings January 6, 2026 00:33

Copilot AI reviewed Jan 6, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Adding further aie4 shim test support #895

Adding further aie4 shim test support #895

hlaccabu commented Dec 3, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Dec 3, 2025

Uh oh!

xdavidz Dec 6, 2025

Uh oh!

xdavidz left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 6, 2026

Uh oh!

Copilot AI Jan 6, 2026

Uh oh!

Copilot AI Jan 6, 2026

Uh oh!

Copilot AI Jan 6, 2026

Uh oh!

Copilot AI Jan 6, 2026

Uh oh!

Copilot AI Jan 6, 2026

Uh oh!

Copilot AI Jan 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	kernel_type == KERNEL_TYPE_TXN_FULL_ELF);
	kernel_type == KERNEL_TYPE_TXN_FULL_ELF);

Adding further aie4 shim test support #895

Are you sure you want to change the base?

Adding further aie4 shim test support #895

Conversation

hlaccabu commented Dec 3, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

xdavidz Dec 6, 2025

Choose a reason for hiding this comment

Uh oh!

xdavidz left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants