Add support for signature versions #57
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@aminalaee or @hannal or @mmzeynalli or @Shauryadhaka would you be able to take a look at this? This would allow https://github.com/opsmill/infrahub to setup other S3 backed storage. |
aminalaee
reviewed
May 26, 2025
Owner
aminalaee
left a comment
aminalaee
left a comment
There was a problem hiding this comment.
Sorry it's been a really long time, I finally could take a look
| aws_secret_access_key=self.AWS_SECRET_ACCESS_KEY, | ||
| ) | ||
|
|
||
| if self.AWS_SIGNATURE_VERSIONS == "s3": |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some S3 storage requires using different signature versions. Boto3 defines this as a configuration item.
https://boto3.amazonaws.com/v1/documentation/api/latest/guide/configuration.html
Some examples are: