This repository was archived by the owner on Apr 24, 2018. It is now read-only.
Added second button#386
Open
kevindekemele wants to merge 2 commits intoamlcurran:masterfrom
kevindekemele:master
Open
Added second button#386kevindekemele wants to merge 2 commits intoamlcurran:masterfrom kevindekemele:master
kevindekemele wants to merge 2 commits intoamlcurran:masterfrom
kevindekemele:master
Conversation
|
|
||
|
|
||
|
|
||
| public void overrideButtonsClick(OnClickListener listener1,OnClickListener listener2) { |
Owner
There was a problem hiding this comment.
I'd prefer not to have this method, just having the two overrideButtonTwoClick and overrideButtonClick methods
Owner
|
Like the idea but there are a few things I'd like to see changed :) just trying to make the code as great together as we can!
If you'd like me to, I could create a PR with what I'm thinking? |
Owner
|
Then we can compare the two |
Author
|
Sure! You can perform your pull request with your thoughts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added second button + a demo in the sample app.
Second button can be added with Builder. Has similar methods as the 'Endbutton' methods.