Add more tests #1293
Draft
Add more tests #1293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgetz
reviewed
May 21, 2025
Contributor
rgetz
left a comment
rgetz
left a comment
There was a problem hiding this comment.
There isn't any doc in here on how to use the tests? or what to expect? or what hardware is needed?
CMakeLists.txt
Outdated
| enable_testing() | ||
| add_subdirectory(tests) | ||
| if(TESTS_COVERAGE) | ||
| if(NOT WITH_GCOV) |
Contributor
There was a problem hiding this comment.
why not just use if (NOT WITH_GCOV) and not include another flag? (TESTS_COVERAGE)?
Contributor
There was a problem hiding this comment.
This is why we need to minimize the configure options :)
./CMakeLists.txt defines "TESTS" as option, but it is missing toggle_iio_feature
./CMakeLists.txt defines "TESTS_COVERAGE" as option, but it is missing toggle_iio_feature
./CMakeLists.txt defines "TESTS_DEBUG" as option, but it is missing toggle_iio_feature
:)
Contributor
Author
There was a problem hiding this comment.
Fixed. TESTS_COVERAGE no longer exists as it has been replaced with WITH_GCOV.
Signed-off-by: Travis F. Collins <[email protected]>
Signed-off-by: Travis F. Collins <[email protected]>
Signed-off-by: Travis F. Collins <[email protected]>
Signed-off-by: Dan Nechita <[email protected]>
Signed-off-by: Dan Nechita <[email protected]>
Signed-off-by: Dan Nechita <[email protected]>
Signed-off-by: Dan Nechita <[email protected]>
Signed-off-by: Dan Nechita <[email protected]>
Signed-off-by: Dan Nechita <[email protected]>
Signed-off-by: Dan Nechita <[email protected]>
Signed-off-by: Dan Nechita <[email protected]>
Signed-off-by: Dan Nechita <[email protected]>
Signed-off-by: Dan Nechita <[email protected]>
Signed-off-by: Dan Nechita <[email protected]>
Signed-off-by: Dan Nechita <[email protected]>
Signed-off-by: Dan Nechita <[email protected]>
Signed-off-by: Dan Nechita <[email protected]>
Signed-off-by: Dan Nechita <[email protected]>
Signed-off-by: Dan Nechita <[email protected]>
Signed-off-by: Dan Nechita <[email protected]>
Signed-off-by: Dan Nechita <[email protected]>
dNechita
force-pushed
the
add-more-standalone-tests
branch
from
fe0533a to
0de7516
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR is based on @tfcollins work that added the test infrastructure and a test for AD9361 buffers.
Additionally, this PR adds tests that cover the following parts of the API:
PR Type
PR Checklist