Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
aioirtc only uses the first ICE serverin a list. This might be a problem when default TURN over UDP doesn't work. TURN over TLS has the highest likelihood for success.
As the PythonSDK targets backend use cases, the use of TCP transport is not a major concern.
Summary by cubic
Prioritizes TURN over TLS in ICE server URLs so aiortc picks the most reliable option first, improving WebRTC connection success when UDP TURN fails.
Bug Fixes
Dependencies
Written for commit 6f159cf. Summary will update on new commits.