fix: accumulate counts when combining mutations#19
Merged
Conversation
Use += when adding an already-existing combined mutation so counts are summed instead of overwritten.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the mutation chaining logic in the
check_mutation_chainfunction and adds a new unit test to verify its correctness. The main improvements are in how mutations are combined.Mutation chaining logic update:
check_mutation_chaininconvert_paths2barcodes.pyto increment the count of an existing mutation when combining mutations, rather than setting it to 1. This ensures that mutation counts are accurately preserved during chaining.Testing enhancements:
test_check_mutation_chainintest_barcoding.pyto verify that mutation chaining produces the expected barcode output when combining mutations.Example:
Bug: The code collapses
A225G > G225TtoA225T. SinceA225Tis already present in the mutations path instead of incrementing the count of seeing the mutation to2it sets to1.Fix: The code has now been patched to increment the count.
lineage_path.txt