Skip to content

Migrate off legacy, stateful expectFailure. #2477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Mar 6, 2026
+5 −8
Merged

Migrate off legacy, stateful expectFailure. #2477

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions ext/truth/javatests/androidx/test/ext/truth/os/ParcelableSubjectTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,19 +18,16 @@
import static androidx.test.ext.truth.os.ParcelableSubject.assertThat;
import static androidx.test.ext.truth.os.ParcelableSubject.parcelables;
import static com.google.common.truth.ExpectFailure.assertThat;
import static com.google.common.truth.ExpectFailure.expectFailureAbout;

import android.accounts.Account;
import androidx.test.ext.junit.runners.AndroidJUnit4;
import com.google.common.truth.ExpectFailure;
import org.junit.Rule;
import org.junit.Test;
import org.junit.runner.RunWith;

@RunWith(AndroidJUnit4.class)
public final class ParcelableSubjectTest {

@Rule public final ExpectFailure expectFailure = new ExpectFailure();

@Test
public void marshallsEquallyTo() {
Account account = new Account("name", "type");
Expand All @@ -42,9 +39,9 @@ public void marshallsEquallyTo() {
public void marshallsEquallyTo_failure() {
Account account = new Account("name", "type");
Account other = new Account("different name", "type");
expectFailure.whenTesting().about(parcelables()).that(account).marshallsEquallyTo(other);
assertThat(expectFailure.getFailure())
.factValue("expected to serialize like")
.isEqualTo(other.toString());
AssertionError failure =
expectFailureAbout(
parcelables(), whenTesting -> whenTesting.that(account).marshallsEquallyTo(other));
assertThat(failure).factValue("expected to serialize like").isEqualTo(other.toString());
}
}
Loading