Skip to content

Update Rust crate toml to v1#1626

Merged
ankoh merged 3 commits intomainfrom
renovate/toml-1.x
Apr 4, 2026
Merged

Update Rust crate toml to v1#1626
ankoh merged 3 commits intomainfrom
renovate/toml-1.x

Conversation

@dashql-renovate
Copy link
Copy Markdown
Contributor

@dashql-renovate dashql-renovate bot commented Mar 21, 2026

  • Investigate CI build failure
  • Identify root cause: packages/tauri-aclgen/BUILD.bazel references @crates//:toml-0.8.23 which no longer exists in the regenerated crate universe after both workspace packages were updated to use the same toml 1.1.2
  • Fix packages/tauri-aclgen/BUILD.bazel to reference @crates//:toml (the new unversioned alias)
  • Fix packages/tauri-aclgen/src/main.rs: replace deprecated toml::de::Deserializer::new (which now returns Result and no longer implements serde::Deserializer) with toml::from_str::<CoreConfig>()

@dashql-renovate dashql-renovate bot added dependencies Pull requests that update a dependency file rust labels Mar 21, 2026
@dashql-renovate dashql-renovate bot force-pushed the renovate/toml-1.x branch from 12bd531 to 8607cfb Compare April 3, 2026 19:31
@ankoh
Copy link
Copy Markdown
Owner

ankoh commented Apr 4, 2026

@copilot check build error:

[4,863 / 9,789] Extracting npm package @tauri-apps/cli-darwin-x64@2.10.1; 0s processwrapper-sandbox ... (4 actions, 1 running)
ERROR: /home/runner/.bazel/external/rules_rust++_crate+++native_crate+crates/BUILD.bazel: no such target '@@rules_rust++_crate+++native_crate+crates//:toml-0.8.23': target 'toml-0.8.23' not declared in package '' defined by /home/runner/.bazel/external/rules_rust++_crate+++native_crate+crates/BUILD.bazel
ERROR: /home/runner/work/dashql/dashql/packages/tauri-aclgen/BUILD.bazel:5:12: no such target '@@rules_rust++_crate+++native_crate+crates//:toml-0.8.23': target 'toml-0.8.23' not declared in package '' defined by /home/runner/.bazel/external/rules_rust++_crate+++native_crate+crates/BUILD.bazel and referenced by '//packages/tauri-aclgen:tauri_aclgen'
Analyzing: 85 targets (609 packages loaded, 13666 targets configured)

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 4, 2026

@copilot check build error:

...

Fixed in a7bb3a8. The issue was that packages/tauri-aclgen/BUILD.bazel still referenced @crates//:toml-0.8.23 after the toml upgrade. Previously, tauri-aclgen used toml 0.8.x and dashql-pack used toml 0.9.x, so crate_universe created two versioned aliases (toml-0.8.23, toml-0.9.12+spec-1.1.0). After both packages were updated to toml 1.1.1, there's only one direct dep version, so crate_universe creates an unversioned toml alias instead. Updated the BUILD.bazel reference to @crates//:toml.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • releases.bazel.build
    • Triggering command: /usr/local/lib/node_modules/@bazel/bazelisk/bazelisk-linux_amd64 /usr/local/lib/node_modules/@bazel/bazelisk/bazelisk-linux_amd64 version (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot finished work on behalf of ankoh April 4, 2026 20:11
Copilot AI requested a review from ankoh April 4, 2026 20:11
@dashql-renovate
Copy link
Copy Markdown
Contributor Author

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@ankoh
Copy link
Copy Markdown
Owner

ankoh commented Apr 4, 2026

@copilot check error:

ERROR: /home/runner/work/dashql/dashql/packages/tauri-aclgen/BUILD.bazel:5:12: Compiling Rust bin tauri_aclgen (1 file) failed: (Exit 1): process_wrapper failed: error executing Rustc command (from rust_binary rule target //packages/tauri-aclgen:tauri_aclgen) bazel-out/k8-fastbuild-exec/bin/external/rules_rust+/util/process_wrapper/process_wrapper --arg-file ... (remaining 226 arguments skipped)

Use --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging
warning: use of deprecated associated function `toml::Deserializer::<'i>::new`: replaced with `Deserializer::parse`
   --> packages/tauri-aclgen/src/main.rs:290:37
    |
290 |             toml::de::Deserializer::new(
    |                                     ^^^
    |
    = note: `#[warn(deprecated)]` on by default

error[E0277]: the trait bound `Result<toml::Deserializer<'_>, toml::de::Error>: serde::de::Deserializer<'de>` is not satisfied
   --> packages/tauri-aclgen/src/main.rs:290:13
    |
289 |           generate_core_permissions(&CoreConfig::deserialize(
    |                                      ----------------------- required by a bound introduced by this call
290 | /             toml::de::Deserializer::new(
291 | |                 &fs::read_to_string(&args.core_config)
292 | |                     .context("failed to read core config")?,
293 | |             ),
    | |_____________^ the trait `_::_serde::Deserializer<'_>` is not implemented for `Result<toml::Deserializer<'_>, toml::de::Error>`
    |
    = help: the following other types implement trait `_::_serde::Deserializer<'de>`:
              &'de serde_json::Map<std::string::String, serde_json::Value>
              &'de serde_json::Value
              &'de serde_json::value::RawValue
              &mut dyn erased_serde::de::Deserializer<'de> + Send + Sync
              &mut dyn erased_serde::de::Deserializer<'de> + Send
              &mut dyn erased_serde::de::Deserializer<'de> + Sync
              &mut dyn erased_serde::de::Deserializer<'de>
              &mut serde_json::Deserializer<R>
            and 49 others
note: required by a bound in `_::_serde::Deserialize::deserialize`
   --> ./external/rules_rust++_crate+++native_crate+crates__serde_core-1.0.228/src/de/mod.rs:561:5

error[E0277]: the trait bound `Result<toml::Deserializer<'_>, toml::de::Error>: serde::de::Deserializer<'de>` is not satisfied
   --> packages/tauri-aclgen/src/main.rs:289:36
    |
289 |           generate_core_permissions(&CoreConfig::deserialize(
    |  ____________________________________^
290 | |             toml::de::Deserializer::new(
291 | |                 &fs::read_to_string(&args.core_config)
292 | |                     .context("failed to read core config")?,
293 | |             ),
294 | |         )?, &work_dir, &args.out_dir)?;
    | |_________^ the trait `_::_serde::Deserializer<'_>` is not implemented for `Result<toml::Deserializer<'_>, toml::de::Error>`
    |
    = help: the following other types implement trait `_::_serde::Deserializer<'de>`:
              &'de serde_json::Map<std::string::String, serde_json::Value>
              &'de serde_json::Value
              &'de serde_json::value::RawValue
              &mut dyn erased_serde::de::Deserializer<'de> + Send + Sync
              &mut dyn erased_serde::de::Deserializer<'de> + Send
              &mut dyn erased_serde::de::Deserializer<'de> + Sync
              &mut dyn erased_serde::de::Deserializer<'de>
              &mut serde_json::Deserializer<R>
            and 49 others

error: aborting due to 2 previous errors; 1 warning emitted

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 4, 2026

@copilot check error:

...

Fixed in ee68851. In toml v1, Deserializer::new now returns Result<Deserializer, Error> instead of Deserializer directly, so it no longer satisfies the serde::Deserializer trait bound. Replaced the usage with toml::from_str::<CoreConfig>() which compiles cleanly.

Copilot finished work on behalf of ankoh April 4, 2026 20:30
@ankoh ankoh merged commit 9d9009a into main Apr 4, 2026
12 checks passed
@ankoh ankoh deleted the renovate/toml-1.x branch April 4, 2026 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file rust

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants