[java20] Fix for #4660: location of parsing tests incorrect. #4661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trash trgen assumes the initial directory location to be that where the desc.xml file resides. Any example inputs should be relative to that. So, "examples/" must be part of the string because "**/*.java" includes not only those .java files in "examples/", but also in "target/" and "Generated-*/"!
kaby76
changed the title
Member
|
@kaby76 thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #4660, where the location of the parser test input files was incorrect. Trash trgen assumes the initial directory is where the desc.xml file resides. Any example inputs should be relative to that. So, "examples/" must be part of the string because "**/*.java" includes not only those .java files with "examples/**/*.java", but also with "target/**/*.java" and "Generated-Java/**/*.java"!