-
Notifications
You must be signed in to change notification settings - Fork 660
fix: 修复 .logo-text 样式冲突问题 #2839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| img[src*='//mapapi.qq.com/web/jsapi/logo/logo_def.png'], | ||
| .logo-text { | ||
| .tmap-contianer--hide-logo img[src*='//mapapi.qq.com/web/jsapi/logo/logo_def.png'], | ||
| .tmap-contianer--hide-logo .logo-text { | ||
| display: none !important; | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| img[src*='//mapapi.qq.com/web/jsapi/logo/logo_def.png'], | ||
| .logo-text { | ||
| .tencent-map--hide-logo img[src*='//mapapi.qq.com/web/jsapi/logo/logo_def.png'], | ||
| .tencent-map--hide-logo .logo-text { | ||
|
Comment on lines
+1
to
+2
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 这个 CSS 文件是用于天地图 ( 建议移除这个不相关的 由于 .tdtmap-container--hide-logo .logo-text { |
||
| display: none !important; | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| img[src*='//mapapi.qq.com/web/jsapi/logo/logo_def.png'], | ||
| .logo-text { | ||
| .tencent-map--hide-logo img[src*='//mapapi.qq.com/web/jsapi/logo/logo_def.png'], | ||
| .tencent-map--hide-logo .logo-text { | ||
|
Comment on lines
+1
to
+2
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 这里的类名
为了修复这个 bug 并提高代码一致性,建议将 TypeScript 文件中使用的类名统一为 请在 // packages/maps/src/tmap/map.ts:507
DOM.addClass(container, 'tencent-map--hide-logo'); |
||
| display: none !important; | ||
| } | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个类名
tmap-contianer--hide-logo中存在一个拼写错误,contianer应该为container。另外,这个 CSS 文件是用于 Google Map (
gmap) 的,但类名以tmap开头,并且img选择器img[src*='//mapapi.qq.com/web/jsapi/logo/logo_def.png']针对的是腾讯地图的 logo。这看起来是错误的。建议进行以下修改:
gmap-container--hide-logo。img选择器,因为它不适用于 Google Map。这样可以使代码更清晰且正确。请记得在
packages/maps/src/gmap/map.ts中也同步更新类名。