fix: normalize longitude for Popup coordinates (fix #2692)#2848
fix: normalize longitude for Popup coordinates (fix #2692)#2848
Conversation
- Add longitude normalization to valid range [-180, 180] in updateLngLatPosition - Fixes Popup not displaying correctly when longitude exceeds 180 degrees
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces longitude normalization to the Popup component to ensure coordinates remain within the [-180, 180] range. While the logic is correctly applied in the coordinate update method, the panToPopup method calculates the normalized value but fails to use it in the map service call. Additionally, it is recommended to extract this normalization logic into a reusable utility function to avoid code duplication and improve maintainability.
| public panToPopup() { | ||
| const { lng, lat } = this.lngLat; | ||
| // Normalize longitude to valid range [-180, 180] | ||
| const normalizedLng = ((lng + 180) % 360 + 360) % 360 - 180; |
There was a problem hiding this comment.
变量 normalizedLng 虽然已经计算，但在第 325 行的 this.mapsService.panTo([lng, lat]) 调用中并未使用。这会导致地图平移时使用的是原始经度而非归一化后的经度，在经度超过 180 度时可能导致平移位置不正确。
| const { lng, lat } = this.lngLat; | ||
| const { x, y } = this.mapsService.lngLatToContainer([lng, lat]); | ||
| // Normalize longitude to valid range [-180, 180] | ||
| const normalizedLng = ((lng + 180) % 360 + 360) % 360 - 180; |
There was a problem hiding this comment.
经度归一化的逻辑 ((lng + 180) % 360 + 360) % 360 - 180 在 panToPopup 和 updateLngLatPosition 中重复出现。建议将其提取为公共的工具函数或类内部的私有方法，以提高代码的可维护性和一致性。
References
- 遵循 DRY (Don't Repeat Yourself) 原则，避免重复的逻辑计算。
1 participant
修复内容
修复 Popup 组件在经度超过180度时无法正确显示的问题。
问题描述
解决方案
updateLngLatPosition方法中添加经度归一化处理修改文件
packages/component/src/popup/popup.ts测试