Refactor manager split code used by fate #6115
Open
+169
−124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Separated out functionality in the manager Splitter class that was only used by the fate split operation. This avoids having to expose code used by TGW to Fate making it easier to execute fate operation outside the manager.
keith-turner
commented
Feb 5, 2026
| ExecutorService getTabletRefreshThreadPool(); | ||
|
|
||
| Splitter getSplitter(); | ||
| SplitFileCache getSplitFileCache(); |
Contributor
Author
There was a problem hiding this comment.
This change is the driver behind this entire PR. Needed to expose a more narrow type here for fate. Found this while experimenting with distributed fate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separated out functionality in the manager Splitter class that was only used by the fate split operation. This avoids having to expose code used by TGW to Fate making it easier to execute fate operation outside the manager.