AVRO-4136: [c] json encoding of byte[] containing 0x00 #3375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steven-aerts
force-pushed
the
avro-4136
branch
2 times, most recently
from
6a7cab6 to
68ce21c
Compare
martin-g
approved these changes
Jul 22, 2025
martin-g
approved these changes
Oct 23, 2025
Member
martin-g
left a comment
martin-g
left a comment
There was a problem hiding this comment.
LGTM!
How about adding some extra tests for:
- char all_nulls[] = {0x00, 0x00, 0x00};
- char starts_with_null[] = {0x00, 0xDE, 0xAD};
- char ends_with_null[] = {0xDE, 0xAD, 0x00};
martin-g
reviewed
Oct 23, 2025
martin-g
requested changes
Oct 23, 2025
Prevent the fixed and bytes type to be preliminary cut off when they are encoded into the json encoding.
steven-aerts
force-pushed
the
avro-4136
branch
from
19f85fa to
abcb520
Compare
martin-g
approved these changes
Oct 24, 2025
Member
|
Thank you, @steven-aerts ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent the fixed and bytes type to be preliminary cut off when they are encoded into the json encoding.
Verifying this change
This change added tests and can be verified as follows: We updated the existing
test_avro_datatests to validate this corner case.Documentation