Fix inconsistent data type in GenericRecord and AvroSchema for AvroWriter

[Abacn]

Fix #36735

Please add a meaningful description for your change here

• Fix inconsistent data type in GenericRecord and AvroSchema for AvroWriter

• Fixed PortableBigQueryDestinations not honoring avroschema attached to AvroWriteRequest, causing Avro Schema is inferred from Beam schema for every element.

---

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

• Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
• Update CHANGES.md with noteworthy changes.
• If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

[gemini-code-assist]

Summary of Changes

Hello @Abacn, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a critical data type inconsistency and performance issue within the Avro writing mechanism, particularly affecting PortableBigQueryDestinations. By ensuring that the AvroWriter correctly utilizes the provided Avro schema from AvroWriteRequest and implementing robust numeric type up-casting in AvroUtils, the changes prevent redundant schema inference and maintain data integrity during conversion from Beam Row to Avro GenericRecord. This ultimately leads to more reliable and efficient data serialization.

Highlights

• Avro Schema Honoring: Fixed an issue in PortableBigQueryDestinations where the AvroWriter was not honoring the explicitly attached Avro schema in AvroWriteRequest, leading to inefficient schema inference per element.
• Data Type Consistency: Introduced logic in AvroUtils to handle implicit numeric type up-casting (e.g., int to long, float to double) when converting Beam Row values to Avro GenericRecord, ensuring consistency with the target Avro schema.
• Enhanced Testing: Updated BigQueryFileLoadsSchemaTransformProviderTest with a more comprehensive schema including a nullable INT32 field and corresponding test data to validate the schema handling improvements.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[Abacn]

This mirrors apache/avro#737

[Abacn]

R: @tarun-google @ahmedabu98

[github-actions]

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

[Abacn]

/gemini review

[gemini-code-assist]

Code Review

This pull request introduces two important fixes. First, it resolves an issue with inconsistent data types during Avro conversion by ensuring that numeric types are correctly cast based on the target Avro schema. Second, it corrects the behavior of PortableBigQueryDestinations to properly use the provided Avro schema instead of re-inferring it. The changes look correct and are well-tested. I've added a couple of suggestions to refactor the new conversion logic in AvroUtils to improve its maintainability and readability by using a map for the conversion functions.

[tarun-google]

LGTM, Thanks for fixing !!

see if we can incorporate both Gemini suggestions for clean code.

[Abacn]

testCdcUsingHexSequenceNum (org.apache.beam.sdk.io.gcp.bigquery.StorageApiSinkRowUpdateIT) failed not related to the change. Test passed on previous commit. merging for now.