Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdks/python/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -485,7 +485,7 @@ def get_portability_package_data():
'google-cloud-spanner>=3.0.0,<4',
# GCP Packages required by ML functionality
'google-cloud-dlp>=3.0.0,<4',
'google-cloud-kms>=3.0.0,<4',
'google-cloud-kms>=3.1.0,<4',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any context on how this fixes the issue? It seems harmless, so I'm fine adding it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I was doing it, there was no kms, but after rebasing I found that you added it in another PR, I set 3.1.0 because it should support Python 3.13: https://pypi.org/project/google-cloud-kms/3.1.0/. Don't know if it is important though

'google-cloud-language>=2.0,<3',
'google-cloud-secret-manager>=2.0,<3',
'google-cloud-videointelligence>=2.0,<3',
Expand Down
Loading