Skip to content

Conversation

@cclauss
Copy link
Contributor

@cclauss cclauss commented Nov 5, 2025

Fixes: #590

Thanks for your contribution to Apache Commons! Your help is appreciated!

Before you push a pull request, review this list:

  • Read the contribution guidelines for this project.
  • Read the ASF Generative Tooling Guidance if you use Artificial Intelligence (AI).
  • I used AI to create any part of, or all of, this pull request.
  • Run a successful build using the default Maven goal with mvn; that's mvn on the command line by itself.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process.

Copy link

@ppkarwasz ppkarwasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @cclauss,

Thanks for the PR! As I noted in #590 (comment), this will cause a problem for the combination os == 'macos-latest' and java == '8', due to the lack of a Temurin JDK 8 distribution for ARM64.

You can fix it by modifying the JDK setup step:

- name: Set up JDK ${{ matrix.java }}
  uses: actions/setup-java@dded0888837ed1f317902acf8a20df0ad188d165 # v5.0.0
  with:
    distribution: ${{ runner.arch == 'ARM64' && matrix.java == '8' && 'zulu' || 'temurin' }}
    java-version: ${{ matrix.java }}

@cclauss
Copy link
Contributor Author

cclauss commented Nov 5, 2025

runner.arch == 'ARM64' could be Linux or Windows on ARM, so let's constrain this to runner.os == 'macOS'

Copy link

@ppkarwasz ppkarwasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@garydgregory
Copy link
Member

FTR, this is related to my post on actions/runner-images#13046
Thank you @cclauss !

@garydgregory garydgregory merged commit 0d0e5e3 into apache:master Nov 5, 2025
13 of 14 checks passed
@cclauss cclauss deleted the patch-2 branch November 5, 2025 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants