Make call to beanutils.ConvertUtils optional (fixes JXPATH-190)#13
Open
TobiX wants to merge 1 commit intoapache:masterfrom
Open
Make call to beanutils.ConvertUtils optional (fixes JXPATH-190)#13TobiX wants to merge 1 commit intoapache:masterfrom
TobiX wants to merge 1 commit intoapache:masterfrom
Conversation
Author
|
Test failure is not releated to this pull request, a quick bisect shows its broken quite a long time... org.apache.commons.jxpath.ri.model.dynabeans.LazyDynaBeanTest#testLazyProperty should probably not be named "testLazyProperty", since it's not the main JUnit test. |
Author
|
Why was this closed? |
|
The PR was against trunk |
TobiX
force-pushed
the
fix-JXPATH-190
branch
from
3fff47b to
0e8dc36
Compare
TobiX
force-pushed
the
fix-JXPATH-190
branch
3 times, most recently
from
d9abb6d to
3b0f302
Compare
Author
|
Ping @garydgregory - Since you have worked on this project recently, would you be willing to review and merge this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://issues.apache.org/jira/browse/JXPATH-190