feat: implement partition_statistics for WindowAggExec #18534
+95
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
0xPoe
commented
Nov 7, 2025
|
|
||
| fn statistics_inner(&self) -> Result<Statistics> { | ||
| let input_stat = self.input.partition_statistics(None)?; | ||
| fn statistics_inner(&self, partition: Option<usize>) -> Result<Statistics> { |
Contributor
Author
There was a problem hiding this comment.
We may want to move the code directly into the partition_statistics and remove this inner function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
partition_statisticsAPI for more operators #15873Rationale for this change
What changes are included in this PR?
Implemented partition_statistics for WindowAggExec.
Are these changes tested?
Check the unit tests.
Are there any user-facing changes?
No