Skip to content

Conversation

@davidlghellin
Copy link
Contributor

Which issue does this PR close?

part of #15914

Rationale for this change

Migrate spark functions from https://github.com/lakehq/sail/ to datafusion engine to unify codebase

What changes are included in this PR?

implement spark udaf try_sum
https://spark.apache.org/docs/latest/api/sql/index.html#try_sum

Are these changes tested?

unit-tests and sqllogictests added

Are there any user-facing changes?

now can be called in queries

@github-actions github-actions bot added sqllogictest SQL Logic Tests (.slt) spark labels Nov 9, 2025
@davidlghellin davidlghellin marked this pull request as draft November 9, 2025 18:42
@davidlghellin davidlghellin marked this pull request as ready for review November 9, 2025 22:11
@davidlghellin davidlghellin changed the title feat(spark): implement Spark try_sum function feat(spark): implement Spark try_sum function Nov 9, 2025
Copy link
Contributor

@Jefffrey Jefffrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way we can leverage the existing sum code in DataFusion to achieve this, instead of adding an entirely new implementation?

https://github.com/apache/datafusion/blob/f162fd325565e14be8e4cace17d8a3a8b2764cc8/datafusion/functions-aggregate/src/sum.rs

@davidlghellin davidlghellin marked this pull request as draft November 10, 2025 07:47
@davidlghellin
Copy link
Contributor Author

Is there a way we can leverage the existing sum code in DataFusion to achieve this, instead of adding an entirely new implementation?

https://github.com/apache/datafusion/blob/f162fd325565e14be8e4cace17d8a3a8b2764cc8/datafusion/functions-aggregate/src/sum.rs

Thanks, I try

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

spark sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants