Misc improvements to ProjectionExprs #18719
Open
+135
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR enhances the physical-expr projection handling with several improvements needed for better projection management in datasources.
Changes
Add trait implementations:
PartialEqandEqforProjectionExprPartialEqandEqforProjectionExprsAdd
project_batch()method:RecordBatchwith pre-computed schemaFix
update_expr()bug:Nonefor literal expressions (no column references)Some(expr)for bothUnchangedandRewrittenValidstatesSELECT 1 FROM tablewhere no file columns are neededChange
from_indices()signature:&SchemaRefto&Schemafor consistencyAdd comprehensive tests:
test_merge_empty_projection_with_literal()- Reproduces roundtrip issuetest_update_expr_with_literal()- Tests literal handlingtest_update_expr_with_complex_literal_expr()- Tests mixed expressionsPart of
This PR is part of #18627 - a larger effort to refactor projection handling in DataFusion.
Testing
All tests pass: