[feature](partition prune) support remove predicates that are always true after partition prune in list partition #57169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
TPC-DS: Total hot run time: 190630 ms |
ClickBench: Total hot run time: 30.51 s |
Contributor
FE UT Coverage ReportIncrement line coverage |
Contributor
FE Regression Coverage ReportIncrement line coverage |
feiniaofeiafei
force-pushed
the
support_prune_predicate
branch
from
67a10c5 to
f95f6dd
Compare
Contributor
Author
|
run buildall |
TPC-DS: Total hot run time: 189897 ms |
ClickBench: Total hot run time: 28.68 s |
Contributor
FE Regression Coverage ReportIncrement line coverage |
Contributor
Author
|
run buildall |
Contributor
FE Regression Coverage ReportIncrement line coverage |
Contributor
Author
|
run performance |
TPC-H: Total hot run time: 35603 ms |
ClickBench: Total hot run time: 29.91 s |
Contributor
Author
|
run buildall |
ClickBench: Total hot run time: 28.01 s |
Contributor
Author
|
run buildall |
TPC-DS: Total hot run time: 190730 ms |
ClickBench: Total hot run time: 27.75 s |
Contributor
Author
|
run nonConcurrent |
Contributor
FE Regression Coverage ReportIncrement line coverage |
1 similar comment
Contributor
FE Regression Coverage ReportIncrement line coverage |
924060929
reviewed
Oct 23, 2025
| partitionSlots, filter.getPredicate(), nameToPartitionItem, ctx, | ||
| PartitionTableType.EXTERNAL, sortedPartitionRanges)); | ||
| PartitionTableType.EXTERNAL, sortedPartitionRanges); | ||
| List<String> prunedPartitions = new ArrayList<>(res.first); |
Contributor
There was a problem hiding this comment.
we support prune predicates for the external table in the future
924060929
previously approved these changes
Oct 23, 2025
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
FE UT Coverage ReportIncrement line coverage |
ClickBench: Total hot run time: 27.84 s |
Contributor
FE Regression Coverage ReportIncrement line coverage |
Contributor
Author
|
run nonConcurrent |
924060929
approved these changes
Oct 28, 2025
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
这个pr会导致统计信息推导出问题.因为我们并不是所有表都收集的partition的行数. 所以如果我们10个分区裁剪了9个,但因为没有partition的行数,那么估行时,我们会认为table输出了全部行,而不是部分行. |
morrySnow
approved these changes
Nov 3, 2025
16 tasks
16 tasks
feiniaofeiafei
added a commit
to feiniaofeiafei/doris
that referenced
this pull request
Nov 14, 2025
…true after partition prune in list partition (apache#57169) Problem Summary: After partition pruning on a list-partitioned table, the partitioning key predicates used for pruning are often redundant within the remaining partitions, leading to unnecessary column scan and computation. Given a table: CREATE TABLE sales ( id INT, region VARCHAR(10) ) PARTITION BY LIST (region) ( PARTITION p_north VALUES IN ('bj', 'tj'), PARTITION p_south VALUES IN ('gz', 'sz') ); query: SELECT * FROM sales WHERE region IN ('bj', 'tj'); Plan Before: -> TableReader(Partition p_north) -> TableScan(Filter: region in ('bj', 'tj')) Plan After: -> TableReader(Partition p_north) -> TableScan() // Filter is removed
feiniaofeiafei
added a commit
to feiniaofeiafei/doris
that referenced
this pull request
Nov 14, 2025
…prune predicate after partition prune (apache#57688) Add session variable skip_prune_predicate to skip prune predicate after partition prune. Related PR: apache#57169
feiniaofeiafei
added a commit
to feiniaofeiafei/doris
that referenced
this pull request
Nov 14, 2025
…ache#57817) Related PR: apache#57169 Problem Summary: Previous pr only skip prune predicate when run delete command, forget to skip prune predicate when explain delete stmt. To solve this problem, this pr skip prune predicate when explain delete stmt and add some cases for update and delete.
wyxxxcat
pushed a commit
to wyxxxcat/doris
that referenced
this pull request
Nov 18, 2025
…true after partition prune in list partition (apache#57169) ### What problem does this PR solve? Problem Summary: After partition pruning on a list-partitioned table, the partitioning key predicates used for pruning are often redundant within the remaining partitions, leading to unnecessary column scan and computation. Given a table: CREATE TABLE sales ( id INT, region VARCHAR(10) ) PARTITION BY LIST (region) ( PARTITION p_north VALUES IN ('bj', 'tj'), PARTITION p_south VALUES IN ('gz', 'sz') ); query: SELECT * FROM sales WHERE region IN ('bj', 'tj'); Plan Before: -> TableReader(Partition p_north) -> TableScan(Filter: region in ('bj', 'tj')) Plan After: -> TableReader(Partition p_north) -> TableScan() // Filter is removed
wyxxxcat
pushed a commit
to wyxxxcat/doris
that referenced
this pull request
Nov 18, 2025
…prune predicate after partition prune (apache#57688) Add session variable skip_prune_predicate to skip prune predicate after partition prune. Related PR: apache#57169
wyxxxcat
pushed a commit
to wyxxxcat/doris
that referenced
this pull request
Nov 18, 2025
…ache#57817) Related PR: apache#57169 Problem Summary: Previous pr only skip prune predicate when run delete command, forget to skip prune predicate when explain delete stmt. To solve this problem, this pr skip prune predicate when explain delete stmt and add some cases for update and delete.
feiniaofeiafei
added a commit
to feiniaofeiafei/doris
that referenced
this pull request
Nov 25, 2025
…true after partition prune in list partition (apache#57169) Problem Summary: After partition pruning on a list-partitioned table, the partitioning key predicates used for pruning are often redundant within the remaining partitions, leading to unnecessary column scan and computation. Given a table: CREATE TABLE sales ( id INT, region VARCHAR(10) ) PARTITION BY LIST (region) ( PARTITION p_north VALUES IN ('bj', 'tj'), PARTITION p_south VALUES IN ('gz', 'sz') ); query: SELECT * FROM sales WHERE region IN ('bj', 'tj'); Plan Before: -> TableReader(Partition p_north) -> TableScan(Filter: region in ('bj', 'tj')) Plan After: -> TableReader(Partition p_north) -> TableScan() // Filter is removed
feiniaofeiafei
added a commit
to feiniaofeiafei/doris
that referenced
this pull request
Nov 25, 2025
…prune predicate after partition prune (apache#57688) Add session variable skip_prune_predicate to skip prune predicate after partition prune. Related PR: apache#57169
feiniaofeiafei
added a commit
to feiniaofeiafei/doris
that referenced
this pull request
Nov 25, 2025
…ache#57817) Related PR: apache#57169 Problem Summary: Previous pr only skip prune predicate when run delete command, forget to skip prune predicate when explain delete stmt. To solve this problem, this pr skip prune predicate when explain delete stmt and add some cases for update and delete.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
After partition pruning on a list-partitioned table, the partitioning key predicates used for pruning are often redundant within the remaining partitions, leading to unnecessary column scan and computation.
Given a table:
Plan Before:
Plan After:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)