[thirdparty](patch) Support a better way to get offset in cctz #57999
+176
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
Open
16 tasks
TPC-H: Total hot run time: 34794 ms |
TPC-DS: Total hot run time: 187525 ms |
ClickBench: Total hot run time: 27.92 s |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
Author
|
run p0 |
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
Author
|
run buildall |
github-actions
bot
removed
the
approved
TPC-H: Total hot run time: 34174 ms |
TPC-DS: Total hot run time: 188174 ms |
ClickBench: Total hot run time: 27.43 s |
morningman
approved these changes
Nov 14, 2025
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
Author
|
run p0 |
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
morningman
approved these changes
Nov 15, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Nov 15, 2025
### What problem does this PR solve? Issue Number: close #xxx Related PR: #xxx Problem Summary: The construction cost of civil_second in cctz is expensive, details can be seen: #57423. In some cases, we do not need to construct the complete civil_time, but only the UTC offset is required, like:`HOUR(FROM_UNIXTIME(ts))` This PR supports the lookup_offset function in cctz, which has the same return type as lookup, but the civil_second is empty, avoiding the expensive construction cost. ```cpp return {{}, utc_offset, is_dst, abbreviations[abbr_index]}; ```
github-actions bot
pushed a commit
that referenced
this pull request
Nov 15, 2025
### What problem does this PR solve? Issue Number: close #xxx Related PR: #xxx Problem Summary: The construction cost of civil_second in cctz is expensive, details can be seen: #57423. In some cases, we do not need to construct the complete civil_time, but only the UTC offset is required, like:`HOUR(FROM_UNIXTIME(ts))` This PR supports the lookup_offset function in cctz, which has the same return type as lookup, but the civil_second is empty, avoiding the expensive construction cost. ```cpp return {{}, utc_offset, is_dst, abbreviations[abbr_index]}; ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
The construction cost of civil_second in cctz is expensive, details can be seen: #57423.
In some cases, we do not need to construct the complete civil_time, but only the UTC offset is required, like:
HOUR(FROM_UNIXTIME(ts))This PR supports the lookup_offset function in cctz, which has the same return type as lookup, but the civil_second is empty, avoiding the expensive construction cost.
return {{}, utc_offset, is_dst, abbreviations[abbr_index]};Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)