Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ public Lag withChildren(List<Expression> children) {
}

@Override
public void checkLegalityBeforeTypeCoercion() {
public void checkLegalityAfterRewrite() {
if (children().size() == 1) {
return;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ public <R, C> R accept(ExpressionVisitor<R, C> visitor, C context) {
}

@Override
public void checkLegalityBeforeTypeCoercion() {
public void checkLegalityAfterRewrite() {
if (children().size() == 1) {
return;
}
Expand All @@ -107,7 +107,7 @@ public void checkLegalityBeforeTypeCoercion() {
}
} else {
throw new AnalysisException(
"The offset parameter of LAG must be a constant positive integer: " + this.toSql());
"The offset parameter of LEAD must be a constant positive integer: " + this.toSql());
}
}
}
Expand Down
25 changes: 25 additions & 0 deletions regression-test/data/nereids_syntax_p0/lag_lead_signature.out
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
-- This file is automatically generated. You should know what you did if you want to edit this
-- !sql1 --
0
0

-- !sql2 --
0
44

-- !sql3 --
0
0

-- !sql4 --
0
0

-- !sql5 --
0
28

-- !sql6 --
0
0

31 changes: 29 additions & 2 deletions regression-test/suites/nereids_syntax_p0/lag_lead_signature.groovy
Original file line number Diff line number Diff line change
Expand Up @@ -20,16 +20,43 @@ suite("lag_lead_signature") {
sql "SET enable_fallback_to_original_planner=false"
sql """drop table if exists lag_lead_signature_t"""
sql """ CREATE TABLE lag_lead_signature_t (
`k` VARCHAR(200) NULL
`k` VARCHAR(200) NULL,
`id` BIGINT NULL
) ENGINE=OLAP
DUPLICATE KEY(`k`)
DISTRIBUTED BY HASH(`k`) BUCKETS 3
PROPERTIES (
"replication_allocation" = "tag.location.default: 1"
);"""

sql "insert into lag_lead_signature_t values ('44'), ('28');"
sql "insert into lag_lead_signature_t values ('44','10'), ('28','11');"

sql "select lag(k, 1, 0) over(), lead(k, 1, 0) over() from lag_lead_signature_t;"

qt_sql1 "select lag(k, 1 + 1, 0) over(order by id) from lag_lead_signature_t order by 1;"
qt_sql2 "select lag(k, abs(1), 0) over(order by id) from lag_lead_signature_t order by 1;"
qt_sql3 "select lag(k, abs(1) + 1, 0) over(order by id) from lag_lead_signature_t order by 1;"
qt_sql4 "select lead(k, 1 + 1, 0) over(order by id) from lag_lead_signature_t order by 1;"
qt_sql5 "select lead(k, abs(1), 0) over(order by id) from lag_lead_signature_t order by 1;"
qt_sql6 "select lead(k, abs(1) + 1, 0) over(order by id) from lag_lead_signature_t order by 1;"

test {
sql "select lag(k, -100, 0) over() from lag_lead_signature_t;"
exception "be a constant positive integer"
}

test {
sql "select lead(k, -100, 0) over() from lag_lead_signature_t;"
exception "be a constant positive integer"
}

test {
sql "select lead(k, id, 0) over() from lag_lead_signature_t;"
exception "must be a constant value"
}

test {
sql "select lag(k, id, 0) over() from lag_lead_signature_t;"
exception "must be a constant value"
}
}
Loading