Skip to content

branch-4.0: [chore](cleanup) remove useless field is_materialized in SlotDescriptor (#58320) #58384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 28, 2025
Merged

branch-4.0: [chore](cleanup) remove useless field is_materialized in SlotDescriptor (#58320) #58384

merged 1 commit into from
Nov 28, 2025

Conversation

@zclllyybb
Copy link
Contributor

@zclllyybb zclllyybb commented Nov 26, 2025

pick #58320

@zclllyybb zclllyybb requested a review from yiguolei as a code owner November 26, 2025 04:07
@Thearas
Copy link
Contributor

Thearas commented Nov 26, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zclllyybb
Copy link
Contributor Author

zclllyybb commented Nov 26, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Nov 26, 2025

Cloud UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 83.49% (1573/1884)
Line Coverage 67.66% (28053/41459)
Region Coverage 68.19% (13819/20264)
Branch Coverage 58.45% (7370/12610)

@doris-robot
Copy link

doris-robot commented Nov 26, 2025

BE UT Coverage Report

Increment line coverage 38.30% (18/47) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.74% (18180/34469)
Line Coverage 38.11% (165491/434264)
Region Coverage 33.13% (128499/387809)
Branch Coverage 33.92% (55354/163174)

@zclllyybb
Copy link
Contributor Author

zclllyybb commented Nov 26, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Nov 26, 2025

Cloud UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 83.49% (1573/1884)
Line Coverage 67.65% (28049/41459)
Region Coverage 68.15% (13810/20264)
Branch Coverage 58.40% (7364/12610)

@hello-stephen
Copy link
Contributor

hello-stephen commented Nov 26, 2025

FE UT Coverage Report

Increment line coverage `` 🎉
Increment coverage report
Complete coverage report

@hello-stephen
Copy link
Contributor

hello-stephen commented Nov 26, 2025

BE UT Coverage Report

Increment line coverage 38.30% (18/47) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.75% (18182/34471)
Line Coverage 38.11% (165497/434265)
Region Coverage 33.13% (128511/387853)
Branch Coverage 33.92% (55357/163182)

@zclllyybb
[chore](cleanup) remove useless field is_materialized in SlotDescript…
f7533f0 
…or (apache#58320)

removed `is_materialized` and `need_materialize` in BE. tagged with
deprecated in thrift and protobuf. remove `need_materialize` in FE.
@zclllyybb
Copy link
Contributor Author

zclllyybb commented Nov 27, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Nov 27, 2025

Cloud UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 83.49% (1573/1884)
Line Coverage 67.64% (28043/41459)
Region Coverage 68.17% (13813/20264)
Branch Coverage 58.36% (7359/12610)

@doris-robot
Copy link

doris-robot commented Nov 27, 2025

BE UT Coverage Report

Increment line coverage 38.30% (18/47) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.68% (18189/34526)
Line Coverage 38.06% (165504/434878)
Region Coverage 33.08% (128502/388455)
Branch Coverage 33.90% (55361/163298)

@hello-stephen
Copy link
Contributor

hello-stephen commented Nov 28, 2025

FE UT Coverage Report

Increment line coverage `` 🎉
Increment coverage report
Complete coverage report

@yiguolei yiguolei merged commit da92993 into apache:branch-4.0 Nov 28, 2025
22 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zclllyybb @Thearas @doris-robot @hello-stephen @yiguolei