Skip to content

Conversation

@eldenmoon
Copy link
Member

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Nov 27, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@eldenmoon
Copy link
Member Author

run buildall

1 similar comment
@eldenmoon
Copy link
Member Author

run buildall

@hello-stephen
Copy link
Contributor

Cloud UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 80.86% (1707/2111)
Line Coverage 66.85% (29887/44708)
Region Coverage 67.39% (14902/22114)
Branch Coverage 57.55% (7923/13768)

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage 0.00% (0/1) 🎉
Increment coverage report
Complete coverage report

@doris-robot
Copy link

TPC-H: Total hot run time: 34529 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit b730351044dd48eb4d2d02b8c11fa33f0dd8431d, data reload: false

------ Round 1 ----------------------------------
q1	17411	5114	4972	4972
q2	2048	312	198	198
q3	10177	1297	738	738
q4	10219	887	360	360
q5	7528	2535	2285	2285
q6	198	180	142	142
q7	969	799	634	634
q8	9377	1390	1093	1093
q9	7162	5335	5302	5302
q10	6911	2210	1840	1840
q11	529	311	283	283
q12	377	375	228	228
q13	17772	3728	3027	3027
q14	241	242	210	210
q15	598	526	523	523
q16	1065	1016	959	959
q17	622	800	475	475
q18	7570	7161	7116	7116
q19	1093	978	581	581
q20	347	347	232	232
q21	3649	3204	2361	2361
q22	1009	977	970	970
Total cold run time: 106872 ms
Total hot run time: 34529 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5001	4989	4953	4953
q2	327	418	322	322
q3	2154	2689	2292	2292
q4	1293	1742	1307	1307
q5	4236	4432	4594	4432
q6	230	174	136	136
q7	2086	2026	1809	1809
q8	2645	2522	2639	2522
q9	7472	7520	7438	7438
q10	3101	3296	2852	2852
q11	590	528	510	510
q12	677	746	658	658
q13	3508	3987	3299	3299
q14	284	302	284	284
q15	546	522	514	514
q16	1098	1147	1108	1108
q17	1198	1463	1472	1463
q18	8066	7557	7591	7557
q19	872	831	894	831
q20	2009	2099	1823	1823
q21	4637	4295	4275	4275
q22	1056	1026	989	989
Total cold run time: 53086 ms
Total hot run time: 51374 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 184865 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit b730351044dd48eb4d2d02b8c11fa33f0dd8431d, data reload: false

query1	1038	410	394	394
query2	6615	1535	1606	1535
query3	6757	233	220	220
query4	25607	23145	23124	23124
query5	4445	656	480	480
query6	340	247	221	221
query7	4641	511	309	309
query8	298	252	245	245
query9	8701	2602	2557	2557
query10	511	358	312	312
query11	15337	15076	14937	14937
query12	193	122	118	118
query13	1703	561	456	456
query14	10771	8871	8819	8819
query15	211	203	197	197
query16	7321	720	528	528
query17	1261	800	651	651
query18	2016	446	355	355
query19	221	202	182	182
query20	130	129	126	126
query21	222	155	122	122
query22	3890	4048	3854	3854
query23	33184	31884	31985	31884
query24	8507	2481	2410	2410
query25	645	555	494	494
query26	1241	279	171	171
query27	2727	508	347	347
query28	4364	2156	2130	2130
query29	859	653	534	534
query30	317	247	217	217
query31	835	728	639	639
query32	86	82	90	82
query33	616	399	347	347
query34	813	863	540	540
query35	807	825	794	794
query36	882	917	827	827
query37	115	114	90	90
query38	3322	3295	3264	3264
query39	1655	1404	1387	1387
query40	223	129	119	119
query41	64	61	64	61
query42	134	113	112	112
query43	439	461	407	407
query44	1295	755	780	755
query45	199	193	182	182
query46	879	1004	641	641
query47	1668	1719	1655	1655
query48	387	413	331	331
query49	757	490	402	402
query50	681	683	412	412
query51	3983	3893	3858	3858
query52	112	114	106	106
query53	248	264	191	191
query54	304	299	274	274
query55	96	97	97	97
query56	336	319	313	313
query57	1139	1158	1115	1115
query58	280	275	279	275
query59	2356	2430	2266	2266
query60	366	343	360	343
query61	171	194	165	165
query62	811	729	658	658
query63	230	196	198	196
query64	4513	1229	897	897
query65	4033	3977	3991	3977
query66	1165	442	337	337
query67	15187	14969	14746	14746
query68	8208	957	623	623
query69	521	352	298	298
query70	1207	1166	1177	1166
query71	486	344	305	305
query72	5794	4880	4825	4825
query73	697	570	360	360
query74	8808	8860	8704	8704
query75	3996	3341	2805	2805
query76	3752	1130	739	739
query77	813	404	316	316
query78	9447	9791	8949	8949
query79	2034	845	581	581
query80	634	593	488	488
query81	503	275	238	238
query82	455	161	133	133
query83	260	266	250	250
query84	252	111	100	100
query85	1041	491	441	441
query86	341	293	285	285
query87	3462	3584	3368	3368
query88	3559	2309	2304	2304
query89	399	330	302	302
query90	1991	224	219	219
query91	169	171	137	137
query92	79	70	66	66
query93	1142	985	672	672
query94	735	461	343	343
query95	507	410	400	400
query96	502	545	285	285
query97	2894	2987	2856	2856
query98	247	220	208	208
query99	1316	1372	1309	1309
Total cold run time: 271511 ms
Total hot run time: 184865 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 28.36 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit b730351044dd48eb4d2d02b8c11fa33f0dd8431d, data reload: false

query1	0.06	0.05	0.05
query2	0.13	0.07	0.07
query3	0.30	0.07	0.08
query4	1.61	0.10	0.10
query5	0.25	0.24	0.24
query6	1.18	0.66	0.63
query7	0.03	0.03	0.03
query8	0.07	0.07	0.06
query9	0.59	0.51	0.51
query10	0.57	0.55	0.56
query11	0.27	0.14	0.14
query12	0.26	0.15	0.15
query13	0.65	0.61	0.61
query14	1.02	1.00	0.99
query15	0.88	0.83	0.82
query16	0.39	0.38	0.38
query17	1.09	1.01	1.05
query18	0.24	0.23	0.22
query19	1.96	1.82	1.77
query20	0.02	0.02	0.01
query21	15.39	0.28	0.23
query22	4.96	0.09	0.09
query23	15.40	0.38	0.23
query24	2.40	0.46	0.31
query25	0.10	0.10	0.09
query26	0.19	0.18	0.18
query27	0.09	0.10	0.09
query28	3.90	1.34	1.17
query29	12.59	4.00	3.29
query30	0.32	0.13	0.11
query31	2.82	0.62	0.45
query32	3.24	0.59	0.49
query33	3.14	3.02	3.11
query34	17.00	5.12	4.58
query35	4.66	4.72	4.62
query36	0.62	0.49	0.49
query37	0.26	0.09	0.08
query38	0.20	0.06	0.06
query39	0.07	0.06	0.05
query40	0.22	0.19	0.17
query41	0.14	0.07	0.06
query42	0.07	0.04	0.04
query43	0.06	0.05	0.05
Total cold run time: 99.41 s
Total hot run time: 28.36 s

@eldenmoon
Copy link
Member Author

run buildall

@hello-stephen
Copy link
Contributor

Cloud UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 80.86% (1707/2111)
Line Coverage 66.85% (29887/44708)
Region Coverage 67.37% (14898/22114)
Branch Coverage 57.57% (7926/13768)

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage 0.00% (0/1) 🎉
Increment coverage report
Complete coverage report

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 89.47% (17/19) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.89% (18503/34985)
Line Coverage 38.42% (169469/441050)
Region Coverage 33.20% (131469/395952)
Branch Coverage 34.17% (56650/165767)

@doris-robot
Copy link

TPC-H: Total hot run time: 34326 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f953ecedac3720e08f7e4572f47ff130e7212449, data reload: false

------ Round 1 ----------------------------------
q1	17483	5020	4892	4892
q2	2055	307	200	200
q3	10163	1333	755	755
q4	10242	969	372	372
q5	7568	2511	2275	2275
q6	196	177	143	143
q7	956	793	658	658
q8	9353	1429	1080	1080
q9	7128	5258	5331	5258
q10	6878	2241	1843	1843
q11	498	316	308	308
q12	358	366	223	223
q13	17778	3696	3019	3019
q14	225	236	209	209
q15	608	532	513	513
q16	1044	1025	967	967
q17	623	797	519	519
q18	8111	7057	7114	7057
q19	1095	958	568	568
q20	353	347	218	218
q21	3553	3703	2314	2314
q22	1010	995	935	935
Total cold run time: 107278 ms
Total hot run time: 34326 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4961	4956	4910	4910
q2	338	377	307	307
q3	2133	2696	2333	2333
q4	1290	1748	1282	1282
q5	4272	4512	4560	4512
q6	220	178	132	132
q7	2063	2010	1841	1841
q8	2694	2569	2521	2521
q9	7557	7489	7553	7489
q10	3077	3249	2841	2841
q11	591	524	500	500
q12	668	726	619	619
q13	3554	3965	3308	3308
q14	295	308	282	282
q15	541	510	515	510
q16	1080	1131	1085	1085
q17	1154	1632	1458	1458
q18	7951	7883	7702	7702
q19	826	782	818	782
q20	2025	2022	1827	1827
q21	4659	4337	4113	4113
q22	1053	1021	968	968
Total cold run time: 53002 ms
Total hot run time: 51322 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 184766 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f953ecedac3720e08f7e4572f47ff130e7212449, data reload: false

query1	1052	453	389	389
query2	6566	1580	1511	1511
query3	6748	228	224	224
query4	25085	23050	22901	22901
query5	4365	616	476	476
query6	353	249	217	217
query7	4661	512	298	298
query8	298	247	240	240
query9	8714	2589	2587	2587
query10	490	340	304	304
query11	15298	15457	14960	14960
query12	194	124	116	116
query13	1692	562	439	439
query14	11085	8767	8751	8751
query15	215	204	190	190
query16	7634	721	543	543
query17	1254	781	617	617
query18	2034	417	323	323
query19	219	198	193	193
query20	131	122	144	122
query21	212	134	112	112
query22	3865	3975	3910	3910
query23	32793	32059	32206	32059
query24	8492	2383	2393	2383
query25	632	519	453	453
query26	1236	272	187	187
query27	2729	491	359	359
query28	4285	2136	2121	2121
query29	821	669	501	501
query30	308	242	210	210
query31	832	703	608	608
query32	84	83	74	74
query33	616	385	338	338
query34	816	868	536	536
query35	811	814	748	748
query36	877	902	816	816
query37	122	109	90	90
query38	3327	3304	3253	3253
query39	1460	1420	1401	1401
query40	219	132	123	123
query41	66	62	62	62
query42	125	114	115	114
query43	433	459	413	413
query44	1283	760	747	747
query45	211	190	188	188
query46	872	991	636	636
query47	1675	1711	1679	1679
query48	388	428	326	326
query49	795	499	410	410
query50	657	677	418	418
query51	3873	3915	3872	3872
query52	114	120	107	107
query53	238	260	201	201
query54	304	293	277	277
query55	98	96	92	92
query56	330	341	324	324
query57	1127	1172	1077	1077
query58	293	269	289	269
query59	2291	2471	2375	2375
query60	351	345	342	342
query61	164	154	160	154
query62	797	722	659	659
query63	231	197	197	197
query64	4628	1312	1008	1008
query65	4068	4025	3964	3964
query66	1128	454	368	368
query67	15356	15137	14855	14855
query68	8279	969	632	632
query69	538	356	321	321
query70	1327	1185	1178	1178
query71	430	339	324	324
query72	6064	4956	4862	4862
query73	659	562	349	349
query74	8796	8787	8526	8526
query75	3315	3297	2797	2797
query76	3407	1114	710	710
query77	539	387	312	312
query78	9535	9648	8909	8909
query79	2277	850	576	576
query80	685	590	523	523
query81	505	269	239	239
query82	239	168	135	135
query83	265	264	253	253
query84	257	107	90	90
query85	882	482	455	455
query86	374	289	286	286
query87	3465	3481	3420	3420
query88	3689	2254	2298	2254
query89	387	335	307	307
query90	1988	225	224	224
query91	170	176	145	145
query92	82	68	70	68
query93	2213	992	657	657
query94	747	478	328	328
query95	504	415	411	411
query96	507	558	290	290
query97	2924	3014	2884	2884
query98	245	208	209	208
query99	1357	1415	1276	1276
Total cold run time: 271172 ms
Total hot run time: 184766 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 28.58 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit f953ecedac3720e08f7e4572f47ff130e7212449, data reload: false

query1	0.05	0.05	0.04
query2	0.15	0.07	0.07
query3	0.34	0.08	0.08
query4	1.61	0.11	0.10
query5	0.26	0.25	0.24
query6	1.18	0.64	0.62
query7	0.03	0.02	0.03
query8	0.06	0.06	0.05
query9	0.58	0.52	0.51
query10	0.55	0.55	0.57
query11	0.26	0.14	0.16
query12	0.26	0.14	0.15
query13	0.65	0.62	0.62
query14	1.01	1.01	1.01
query15	0.89	0.82	0.83
query16	0.40	0.39	0.39
query17	1.03	1.05	1.05
query18	0.24	0.21	0.23
query19	1.94	1.85	1.85
query20	0.02	0.02	0.01
query21	15.40	0.28	0.24
query22	4.98	0.12	0.09
query23	15.37	0.38	0.22
query24	2.44	0.43	0.28
query25	0.09	0.10	0.09
query26	0.19	0.18	0.18
query27	0.10	0.10	0.09
query28	3.62	1.36	1.19
query29	12.65	4.06	3.30
query30	0.33	0.14	0.12
query31	2.81	0.64	0.43
query32	3.24	0.60	0.49
query33	3.05	3.06	3.02
query34	16.58	5.12	4.67
query35	4.63	4.71	4.65
query36	0.61	0.50	0.48
query37	0.25	0.09	0.09
query38	0.20	0.05	0.06
query39	0.07	0.05	0.05
query40	0.19	0.17	0.18
query41	0.12	0.06	0.06
query42	0.08	0.05	0.06
query43	0.06	0.06	0.05
Total cold run time: 98.57 s
Total hot run time: 28.58 s

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 89.47% (17/19) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 73.23% (25119/34303)
Line Coverage 60.42% (266225/440656)
Region Coverage 55.65% (223016/400762)
Branch Coverage 57.44% (95726/166662)

@hello-stephen
Copy link
Contributor

FE Regression Coverage Report

Increment line coverage 100.00% (1/1) 🎉
Increment coverage report
Complete coverage report

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 28, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

@csun5285 csun5285 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 94.74% (18/19) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.73% (24605/34303)
Line Coverage 58.27% (256749/440656)
Region Coverage 53.39% (213971/400762)
Branch Coverage 54.88% (91468/166662)

@eldenmoon eldenmoon merged commit a8c222c into apache:master Nov 28, 2025
27 of 30 checks passed
@hello-stephen
Copy link
Contributor

FE Regression Coverage Report

Increment line coverage 100.00% (1/1) 🎉
Increment coverage report
Complete coverage report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants