fix: correct CSV physical cell count#907
Merged
delei merged 2 commits intoapache:mainfrom May 5, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
While looking at the CSV row API from a workbook write handler, I noticed that
CsvRow#getPhysicalNumberOfCells()was returning the row index instead of the number of cells in the row.I checked the implementation and found that
getPhysicalNumberOfCells()was callinggetRowNum(). That means the first row returns0, even when the row actually contains cells. For example, a CSV header row withNo,Name, andAgeshould report3physical cells, but it reported0.What's changed?
I changed
CsvRow#getPhysicalNumberOfCells()to returncellList.size()instead ofgetRowNum().I also added a regression test in
CsvFormatTest. The test writes a CSV file with three header cells, then checks the first row from a workbook write handler and verifies thatgetPhysicalNumberOfCells()returns3.Tested with
CsvFormatTest#testPhysicalNumberOfCells, fullCsvFormatTest, andspotless:check.Checklist