fix: support SQL date types in WriteCellData#912
Open
skytin1004 wants to merge 1 commit intoapache:mainfrom
Open
fix: support SQL date types in WriteCellData#912skytin1004 wants to merge 1 commit intoapache:mainfrom
skytin1004 wants to merge 1 commit intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
Closed: #714
I've fixed
WriteCellData(Date)when the actual value isjava.sql.Dateorjava.sql.Time.I reproduced the failure locally and confirmed that both SQL date/time types can throw
UnsupportedOperationExceptionwhentoInstant()is called directly.What's changed?
WriteCellData(Date)now uses an epoch-millis fallback only forjava.sql.Dateandjava.sql.Time, because those types do not supporttoInstant().The existing
toInstant()path is kept forjava.util.Dateandjava.sql.Timestamp. This keeps the behavior unchanged for regular date values and preservesjava.sql.Timestampnano precision.I added regression tests for:
java.sql.Datejava.sql.Timejava.sql.TimestampTo verify the fix, I first confirmed that the new
WriteCellDataTestfailed before the change withUnsupportedOperationExceptionfromjava.sql.Date.toInstant()andjava.sql.Time.toInstant(). After applying the fix, I confirmed that the new test passed, the existing relatedCellDataDataTestpassed together with it, and the fullfesod-sheettest suite also passed.Checklist