[FLINK-38818] [posgtresql]Build createTableEventCache using TableSchemas from split #4194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
base
postgres-cdc-connector
postgres-pipeline-connector
labels
Mrart
force-pushed
the
FLINK-38818
branch
2 times, most recently
from
a3c7f11 to
d961c5a
Compare
…mas from split and Make transform operator stateless
Mrart
changed the title
lvyanquan
reviewed
Dec 23, 2025
Contributor
lvyanquan
left a comment
lvyanquan
left a comment
There was a problem hiding this comment.
Overall LGTM. left two minor comments.
| debeziumDeserializationSchema.deserialize(element, outputCollector); | ||
| } | ||
|
|
||
| public void applySplit(SourceSplitBase split) {} |
Contributor
There was a problem hiding this comment.
It's better to add some java doc for this newly added public method.
| .collect(Collectors.toList()); | ||
|
|
||
| // Verify that we captured the expected number of data change events | ||
| assertThat(actualDataChangeEvents.size()).isGreaterThanOrEqualTo(expectedBinlog.size()); |
Contributor
There was a problem hiding this comment.
It's better to add a scenario for creating a savepoint and restoring reads from the savepoint here too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As #4056 only support mysql.
We add postgres implement.
`
For historical reasons, the current implementation does not utilize the Source to build a schema cache. This requires the TransformOperator to maintain its own complex state.
An optimization is proposed: to build a reusable schema cache at the Source (or in an operator immediately following it).
The primary benefit of this approach is that the transform operator can be made completely stateless. This simplifies its design, improves architectural modularity, and makes the entire pipeline more robust and maintainable.
`