Add generics to _ArrayIterator and _ArrayEnumeration #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The reason FreeMarker doesn't use generics is that it's not backward compatible to add them to public API-s. So it couldn't adopt them. Even though TemplateElement is in principle internal, it's used by some. |
hduelme
force-pushed
the
add-generics-to-_ArrayIterator-and-_ArrayEnumeration
branch
from
93810d2 to
cd1f5be
Compare
Contributor
Author
|
Good to know, I thought TemplateElement was only an internal API. I removed the change to the API. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the missing generics to
_ArrayIteratorand_ArrayEnumerationand to the places they are used.