Skip to content

Conversation

@liyin398720
Copy link

No description provided.

@necouchman
Copy link
Contributor

@liyin398720 There are several issues with this pull request that need to be resolved before we'd consider merging it:

  • First and most importantly, it builds on work already in progress by @corentin-soriano. I'd highly encourage you to work with Corentin on this effort and either gain his concurrence to continue work on these changes, or, instead, put your work into reviews/comments/changes on his existing pull request (GUACAMOLE-288: Add support for multi-monitor connections. #560).
  • Assuming you do work with Corentin on this, and he agrees that your pull request should be used, you'll need to clean up the commits quite a bit, particularly the commit messages, which should be descriptive of the reason for the changes. "update log", "add log", etc., are not good commit messages. See: https://www.codelord.net/2015/03/16/bad-commit-messages-hall-of-shame/.
  • At this point, there are also conflicts in pull request that have to be resolved, as well.

@corentin-soriano
Copy link
Member

You didn't pull in the latest commits from my branch, so I'm having trouble understanding what you actually changed.

Could you rebase from my branch (after pulling it) and remove the chmod 755 to clean up the diff? Or comment in my PR what you want to change?

@necouchman
Copy link
Contributor

Closing due to lack of response and ongoing work in change #560.

@necouchman necouchman closed this Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants