MAPREDUCE-7535. Setting the JSON provider to the customized one for M…#8298
Merged
brumi1024 merged 2 commits intoapache:trunkfrom Mar 10, 2026
Merged
MAPREDUCE-7535. Setting the JSON provider to the customized one for M…#8298brumi1024 merged 2 commits intoapache:trunkfrom
brumi1024 merged 2 commits intoapache:trunkfrom
Conversation
…R webapp Change-Id: I69d33a9d498e65504d805c6c2b9bdcc646c372c0
|
💔 -1 overall
This message was automatically generated. |
K0K0V0K
approved these changes
Mar 4, 2026
Contributor
K0K0V0K
left a comment
K0K0V0K
left a comment
There was a problem hiding this comment.
Thanks Peter for fixing this up!
LGTM!
Contributor
Author
|
Hi @slfan1989 , @brumi1024, |
brumi1024
reviewed
Mar 9, 2026
| public boolean configure(FeatureContext context) { | ||
| //Auto discovery should be disabled to ensure the custom providers will be used | ||
| context.property(CommonProperties.MOXY_JSON_FEATURE_DISABLE, true); | ||
| context.property("jersey.config.jsonFeature", "JsonProviderFeature"); |
Member
There was a problem hiding this comment.
Nit: instead of hardcoding this org.glassfish.jersey.internal.InternalProperties -> InternalProperties.JSON_FEATURE could maybe used.
Contributor
Author
There was a problem hiding this comment.
Thanks for the review @brumi1024, fixed the property
Change-Id: Iee79bab1f26042dc6e1ed57f5f5931ecb6a7eb16
slfan1989
approved these changes
Mar 9, 2026
|
💔 -1 overall
This message was automatically generated. |
Contributor
Author
|
Thanks a lot @brumi1024 for the review and the merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…R webapp
Change-Id: I69d33a9d498e65504d805c6c2b9bdcc646c372c0
Description of PR
After a customized Moxy JSON provider has been introduced in the MR AM Webapp in MAPREDUCE-7530 we need to set "jersey.config.jsonFeature" property to the customized JsonProviderFeature to prevent automatic discovery of legacy providers like EntityFilteringFeature.
As I could see the jersey-provided moxy in jersey media module also has this configuration, but we are using native moxy in Hadoop, so it is necessary to configure this setting explicitly
How was this patch tested?
Tested MR jobs on a Hadoop cluster
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?AI Tooling
If an AI tool was used:
where is the name of the AI tool used.
https://www.apache.org/legal/generative-tooling.html