Skip to content

HDFS-17892 RBF: permit not released during invokeConcurrent if getOrderedNamenodes throws an exception#8345

Open
dParikesit wants to merge 2 commits intoapache:trunkfrom
dParikesit:4-new-acquirePermit
Open

HDFS-17892 RBF: permit not released during invokeConcurrent if getOrderedNamenodes throws an exception#8345
dParikesit wants to merge 2 commits intoapache:trunkfrom
dParikesit:4-new-acquirePermit

Conversation

@dParikesit
Copy link
Contributor

JIRA: HDFS-17892

Description of PR

After HDFS-17265, we either move acquirePermit after getOrderedNamenodes or wrap getOrderedNamenodes in a try-finally block so that the permit can be released if getOrderedNamenodes throws an exception.

However, the behavior of the latest trunk (a178eb7) has regressed, where we don't handle the permit release anymore.

The test failed to detect this problem because it only use 1 locations. In invokeConcurrent, the execution flows into invokeSingle where the exception is correctly handled using this branch

else if (locations.size() == 1 && timeOutMs <= 0){      
    // Shortcut, just one call       
    return invokeSingle(locations.iterator().next(), method);     
}

In this patch, I've fixed the invokeConcurrent and the test to reflect this behavior.

How was this patch tested?

mvn -pl hadoop-hdfs-project/hadoop-hdfs-rbf -am -Dtest=TestRouterHandlersFairness#testReleasedWhenExceptionOccurs test

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

AI Tooling

If an AI tool was used:

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 0s Docker mode activated.
-1 ❌ patch 0m 25s #8345 does not apply to trunk. Rebase required? Wrong Branch? See https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute for help.
Subsystem Report/Notes
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8345/1/console
versions git=2.34.1
Powered by Apache Yetus 0.14.1 https://yetus.apache.org

This message was automatically generated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants