HDFS-17892 RBF: permit not released during invokeConcurrent if getOrderedNamenodes throws an exception#8345
Open
dParikesit wants to merge 2 commits intoapache:trunkfrom
Open
HDFS-17892 RBF: permit not released during invokeConcurrent if getOrderedNamenodes throws an exception#8345dParikesit wants to merge 2 commits intoapache:trunkfrom
dParikesit wants to merge 2 commits intoapache:trunkfrom
Conversation
|
💔 -1 overall
This message was automatically generated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA: HDFS-17892
Description of PR
After HDFS-17265, we either move acquirePermit after getOrderedNamenodes or wrap getOrderedNamenodes in a try-finally block so that the permit can be released if getOrderedNamenodes throws an exception.
However, the behavior of the latest trunk (a178eb7) has regressed, where we don't handle the permit release anymore.
The test failed to detect this problem because it only use 1 locations. In invokeConcurrent, the execution flows into invokeSingle where the exception is correctly handled using this branch
In this patch, I've fixed the invokeConcurrent and the test to reflect this behavior.
How was this patch tested?
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?AI Tooling
If an AI tool was used:
where is the name of the AI tool used.
https://www.apache.org/legal/generative-tooling.html