Skip to content

LoggingIOSession: Fix off-by-one error #784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rschmitt wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −2
Open

LoggingIOSession: Fix off-by-one error #784

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion httpclient5/src/main/java/org/apache/hc/client5/http/impl/async/LoggingIOSession.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,7 @@ void logData(final ByteBuffer data, final String prefix) {

for (int i = 0; i < chunk; i++) {
final char ch = (char) line[i];
if (ch > Chars.SP && ch <= Chars.DEL) {
if (ch > Chars.SP && ch < Chars.DEL) {
buf.append(ch);
} else if (Character.isWhitespace(ch)) {
buf.append(' ');
Expand Down
2 changes: 1 addition & 1 deletion httpclient5/src/test/java/org/apache/hc/client5/http/impl/async/LoggingIOSessionTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ void allBytes() {
verify(wireLog).debug("IOSession << @ABCDEFGHIJKLMNO 40 41 42 43 44 45 46 47 48 49 4a 4b 4c 4d 4e 4f");
verify(wireLog).debug("IOSession << PQRSTUVWXYZ[\\]^_ 50 51 52 53 54 55 56 57 58 59 5a 5b 5c 5d 5e 5f");
verify(wireLog).debug("IOSession << `abcdefghijklmno 60 61 62 63 64 65 66 67 68 69 6a 6b 6c 6d 6e 6f");
verify(wireLog).debug("IOSession << pqrstuvwxyz{|}~\u007F 70 71 72 73 74 75 76 77 78 79 7a 7b 7c 7d 7e 7f");
verify(wireLog).debug("IOSession << pqrstuvwxyz{|}~. 70 71 72 73 74 75 76 77 78 79 7a 7b 7c 7d 7e 7f");
verify(wireLog).debug("IOSession << ................ 80 81 82 83 84 85 86 87 88 89 8a 8b 8c 8d 8e 8f");
verify(wireLog).debug("IOSession << ................ 90 91 92 93 94 95 96 97 98 99 9a 9b 9c 9d 9e 9f");
verify(wireLog).debug("IOSession << ................ a0 a1 a2 a3 a4 a5 a6 a7 a8 a9 aa ab ac ad ae af");
Expand Down