Skip to content

feat(view): add NewMetadata constructor for views #620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(view): add NewMetadata constructor for views #620

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 34 additions & 17 deletions view/metadata.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,39 @@ func LoadMetadata(ctx context.Context,
return &m, nil
}

// NewMetadata returns a view metadata for a given version.
func NewMetadata(schema *iceberg.Schema,
version Version,
loc string,
props iceberg.Properties,
) Metadata {
// override the corresponding view version fields with the following values.
versionId := int64(1)
Comment on lines +67 to +68
Copy link
Member

@zeroshade zeroshade Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we overriding the version.VersionID with 1?

Copy link
Contributor Author

@twuebi twuebi Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can remove, was thinking it may be better to have a predictable starting point vs whatever is passed in

timestampMs := time.Now().UnixMilli()

if version.SchemaID != schema.ID {
version.SchemaID = schema.ID
}
version.VersionID = versionId
Comment on lines +71 to +74
Copy link
Contributor Author

@twuebi twuebi Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also return an error on mismatch instead

version.TimestampMs = timestampMs

return &metadata{
UUID: uuid.NewString(),
FmtVersion: 1,
Loc: loc,
SchemaList: []*iceberg.Schema{schema},
CurrentVersionId: versionId,
VersionList: []Version{version},
VersionLogList: []VersionLogEntry{
{
TimestampMs: timestampMs,
VersionID: versionId,
},
},
Props: props,
}
}

// CreateMetadata creates a new view metadata file and writes it to storage.
//
// Returns the full path to the created metadata file, or an error if creation fails.
Expand Down Expand Up @@ -89,23 +122,7 @@ func CreateMetadata(
}

metadataLocation = loc + "/metadata/view-" + uuid.New().String() + ".metadata.json"

viewUUID := uuid.New().String()
viewMetadata := metadata{
UUID: viewUUID,
FmtVersion: 1,
Loc: loc,
SchemaList: []*iceberg.Schema{schema},
CurrentVersionId: versionId,
VersionList: []Version{viewVersion},
VersionLogList: []VersionLogEntry{
{
TimestampMs: timestampMs,
VersionID: versionId,
},
},
Props: props,
}
viewMetadata := NewMetadata(schema, viewVersion, loc, props)

viewMetadataBytes, err := json.Marshal(viewMetadata)
if err != nil {
Expand Down
Loading