Skip to content

Conversation

@manuzhang
Copy link
Member

No description provided.

@manuzhang manuzhang added this to the Iceberg 1.10.0 milestone Apr 28, 2025
@github-actions github-actions bot added the core label Apr 28, 2025
@manuzhang manuzhang force-pushed the remove-deprecation-1.10.0 branch from ba359d2 to d60f62f Compare April 28, 2025 02:58
@manuzhang manuzhang force-pushed the remove-deprecation-1.10.0 branch from d60f62f to 26c45ac Compare April 28, 2025 15:36
@manuzhang manuzhang changed the title Core: Remove deprecated RemoveSnapshot Core: Remove deprecations for 1.10.0 Apr 28, 2025
@manuzhang manuzhang force-pushed the remove-deprecation-1.10.0 branch 3 times, most recently from a936280 to 4caff8b Compare April 29, 2025 04:40
@manuzhang manuzhang changed the title Core: Remove deprecations for 1.10.0 AWS, Core, Flink, Parquet: Remove deprecations for 1.10.0 Apr 29, 2025
@manuzhang manuzhang force-pushed the remove-deprecation-1.10.0 branch from 4caff8b to 82e0db2 Compare April 29, 2025 07:02
@nastra nastra requested a review from amogh-jahagirdar April 29, 2025 07:17
@nastra
Copy link
Contributor

nastra commented Apr 29, 2025

Can you also please remove SparkAvroReader from Spark 3.4 + 3.5?

@manuzhang manuzhang force-pushed the remove-deprecation-1.10.0 branch from 82e0db2 to 05a81c2 Compare April 30, 2025 09:34
@github-actions github-actions bot added the spark label Apr 30, 2025
Copy link
Contributor

@nastra nastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the code changes LGTM but we'll need to redo the entire RevAPI exclusions after #12930 gets merged. Also I'm marking this as "request changes" so that we don't accidentally merge this before #12930

@manuzhang manuzhang force-pushed the remove-deprecation-1.10.0 branch from b149442 to 1795f43 Compare May 7, 2025 16:06
Copy link
Contributor

@nastra nastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @manuzhang. @danielcweeks or @amogh-jahagirdar can you guys also please take a look?

@nastra nastra requested a review from danielcweeks May 7, 2025 16:56
Copy link
Contributor

@amogh-jahagirdar amogh-jahagirdar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @manuzhang this looks great to me! I'll go ahead and merge. Thanks @nastra @ebyhr for reviewing.

@amogh-jahagirdar amogh-jahagirdar merged commit 8cf9961 into apache:main May 7, 2025
43 checks passed
devendra-nr pushed a commit to devendra-nr/iceberg that referenced this pull request Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants