Skip to content

Conversation

@Vansittart
Copy link

@Vansittart Vansittart commented Dec 7, 2025

Redirected from issue #46 , the progress:

  • Implemented _install_log_rotation_handler function, which was previously marked as todo;
  • Implemented cleanup_old_log_files function to delete logs based on the configured time threshold;
  • Implemented cleanup_log_files_by_size to limit the maximum size of log files;
  • Added a patch to mitigate race conditions;
  • Fixed issues reported by clippy;
  • The directory needs to be traversed multiple times, this could be merged into a single traversal;
  • metadata() is called multiple times, which has the same issue as mentioned above;
  • Consider splitting cleanup_log_files_by_size into multiple smaller functions;
  • Error handling should not be limited to simple return or continue statements;
  • It would be better to add some certain error message logs;

Before merge:

  • Comprehensive debugging and testing coverage;
  • Verified to comply with Apache specifications;
  • Confirm it is ready for being merged;

Plan:
Around the next two weekends.

@hubcio
Copy link
Contributor

hubcio commented Dec 7, 2025

I think changes in core/message_bus are not related to log retention, looks like merge problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants