IGNITE-25940 .NET: Add ContainsAllKeys to table views#7596
Merged
ptupitsyn merged 11 commits intoapache:mainfrom Feb 18, 2026
Merged
IGNITE-25940 .NET: Add ContainsAllKeys to table views#7596ptupitsyn merged 11 commits intoapache:mainfrom
ptupitsyn merged 11 commits intoapache:mainfrom
Conversation
ptupitsyn
approved these changes
Feb 16, 2026
464f204 to
d9a1e3c
Compare
There was a problem hiding this comment.
Pull request overview
Adds a new .NET table-view API to check existence of multiple keys in one call, wiring it through the thin client protocol and covering it with tests.
Changes:
- Added
ContainsAllKeysAsynctoIRecordView<T>andIKeyValueView<TK, TV>and implemented it in internal view classes. - Introduced a new client operation (
TupleContainsAllKeys) and mapped it through operation typing + retry policy. - Added extensive test coverage (record views, key-value views, binary/POCO variants, partition awareness, compatibility).
Reviewed changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| modules/platforms/dotnet/Apache.Ignite/Table/IRecordView.cs | Public API: adds ContainsAllKeysAsync to record views. |
| modules/platforms/dotnet/Apache.Ignite/Table/IKeyValueView.cs | Public API: adds ContainsAllKeysAsync to key-value views. |
| modules/platforms/dotnet/Apache.Ignite/Internal/Table/RecordView.cs | Implements ContainsAllKeysAsync via new client op. |
| modules/platforms/dotnet/Apache.Ignite/Internal/Table/KeyValueView.cs | Implements ContainsAllKeysAsync by delegating to record view. |
| modules/platforms/dotnet/Apache.Ignite/Internal/Proto/ClientOp.cs | Adds protocol op code TupleContainsAllKeys. |
| modules/platforms/dotnet/Apache.Ignite/Internal/Proto/ClientOpExtensions.cs | Maps new internal op to public ClientOperationType. |
| modules/platforms/dotnet/Apache.Ignite/ClientOperationType.cs | Adds public operation type for diagnostics/retry. |
| modules/platforms/dotnet/Apache.Ignite/RetryReadPolicy.cs | Enables retries for the new read-only operation. |
| modules/platforms/dotnet/Apache.Ignite/ApiCompatibilitySuppressions.xml | Adds API-compat suppressions for the new interface methods. |
| modules/platforms/dotnet/Apache.Ignite.Tests/Table/RecordViewPocoTests.cs | Adds record-view tests for ContainsAllKeysAsync. |
| modules/platforms/dotnet/Apache.Ignite.Tests/Table/RecordViewBinaryTests.cs | Adds binary record-view tests for ContainsAllKeysAsync. |
| modules/platforms/dotnet/Apache.Ignite.Tests/Table/KeyValueViewPrimitiveTests.cs | Adds primitive key-value tests for ContainsAllKeysAsync. |
| modules/platforms/dotnet/Apache.Ignite.Tests/Table/KeyValueViewPrimitivePocoTests.cs | Adds primitive+POCO key-value tests for ContainsAllKeysAsync. |
| modules/platforms/dotnet/Apache.Ignite.Tests/Table/KeyValueViewPocoTests.cs | Adds POCO key-value tests for ContainsAllKeysAsync. |
| modules/platforms/dotnet/Apache.Ignite.Tests/Table/KeyValueViewPocoPrimitiveTests.cs | Adds POCO-key + primitive-value key-value tests for ContainsAllKeysAsync. |
| modules/platforms/dotnet/Apache.Ignite.Tests/Table/KeyValueViewBinaryTests.cs | Adds binary key-value tests for ContainsAllKeysAsync. |
| modules/platforms/dotnet/Apache.Ignite.Tests/PartitionAwarenessTests.cs | Ensures partition awareness routes the new op correctly. |
| modules/platforms/dotnet/Apache.Ignite.Tests/FakeServer.cs | Updates fake server to respond to the new op in unit tests. |
| modules/platforms/dotnet/Apache.Ignite.Tests/Compatibility/CurrentClientWithOldServerCompatibilityTest.cs | Replaces TODO with real compatibility assertions for the new API. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
modules/platforms/dotnet/Apache.Ignite.Tests/Table/KeyValueViewPocoPrimitiveTests.cs
Show resolved
Hide resolved
modules/platforms/dotnet/Apache.Ignite.Tests/Table/KeyValueViewBinaryTests.cs
Show resolved
Hide resolved
modules/platforms/dotnet/Apache.Ignite.Tests/Table/KeyValueViewPocoTests.cs
Show resolved
Hide resolved
d9a8ebc to
4543933
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.